Skip to content

Backwards compatible delete_method - #142

Draft
omus wants to merge 17 commits into
mainfrom
cv/delete-method
Draft

Backwards compatible delete_method#142
omus wants to merge 17 commits into
mainfrom
cv/delete-method

Conversation

@omus

@omus omus commented Nov 25, 2025

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.29%. Comparing base (48aaacf) to head (49d48cb).

Files with missing lines Patch % Lines
src/compat.jl 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   97.22%   95.29%   -1.93%     
==========================================
  Files           6        7       +1     
  Lines         144      170      +26     
==========================================
+ Hits          140      162      +22     
- Misses          4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@omus

omus commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

Dropping Julia 1.0.0 due to:

Expression: Mocking.delete_method(m) === nothing
  type Method has no field primary_world

@omus

omus commented Nov 25, 2025

Copy link
Copy Markdown
Member Author
UndefVarError: invoke_in_world not defined

This was only added in Julia 1.6.

@omus

omus commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

I'll split out the codecov and julia-version change into separate PRs tomorrow. The changes to Base.get_methodtable on Julia 1.12 seem a bit strange to me but it's an internal function and it only really impacts tests. I may dig into it further though.

Comment thread test/compat.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant