Repository navigation
Conversation
馃 Changeset detectedLatest commit: 1e67fa9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing issue
With grace enabled and the default
timeout: 0, a stale value is refreshed in the background, and that factory always getsgracedEntry: undefined. Only the foreground path passes the graced value (FactoryRunner.run(), theshouldSwrbranch calls#runFactorywithoutgracedValue).timeout: 0is the default, so this is the common stale-while-revalidate path. The docs presentgracedEntryas available whenever a graced value exists. A factory can't tell it is only refreshing (e.g. to keep the stale value rather than refetch, or skip work another process is already doing).Proposed fix
pass
gracedValuein the background branch too.Testing context
It appears the existing
can access graced entryasserts inside the factory, which runs in the background under the default timeout. The failing assertion is thrown in the background and swallowed, andassert.plan(2)still counts it, so the test passes with or without the fix. The new test asserts outside the factory, and fails without the fix.Typecheck and eslint pass.
Proposed
patchfor version bumping