Refactor check_submissions - adding API hooks for judging and minor multithreading improvements - #490
Merged
pehrsoderman merged 3 commits intoSep 4, 2026
Conversation
…llelism improvements
Refactors check_submission with several goals in mind: - Easier to follow the logic - (some) preparation for submissions.yaml - a bit less directory hard coding - Use the submissions_judge_factory hook (for API users wanting to modify judging) - Start test cases in larger batches
…more than hard coded directories)
pehrsoderman
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a large refactor on the
check_submissionsmethod. Main technical changes:SubmissionsJudgewhich gets a call with a large batch of submissions to check. This is mainly to allow an API user to hook judging within problemtools, but also lets our multithreading schedule precompute a bit better.check_submissions. I feel like it reads a lot cleaner now (gather up all submissions which lower bound the time limit, run those, compute time limit, run the rest)submissions.yaml)Behavioral changes:
submissions.yaml, submissions can come in arbitrary directories.