feat: DCV support#13
Open
spbsoluble wants to merge 10 commits into
Open
Conversation
The plugin now builds against net10.0 exclusively (dropped net8.0 multi-targeting across all four projects), and DcvSupport now defaults to true — the default/CI-shipped build targets DCV-capable AnyCA Gateway 26.x hosts (Keyfactor.AnyGateway.IAnyCAPlugin 3.3.0, now a stable release) instead of GA 25.5.x. The GA/no-DCV build (IAnyCAPlugin 3.2.0) is now the opt-in path via -p:DcvSupport=false. integration-manifest.json's gateway_framework moves 25.5.0 -> 26.0.0 to match. README regenerated via doctool to reflect the net10.0-only install path and updated compatibility line. Removed the Microsoft.Bcl.AsyncInterfaces/System.IO.Pipelines/System.Text.Encodings.Web TFM-support overrides that are no longer needed on net10.0, and pinned WireMock.Net's transitive Scriban.Signed/System.Linq.Dynamic.Core/ OpenTelemetry.* dependencies past several CVEs surfaced once net10.0 became the only restore target.
…E-delegated DCV - Issue 0005: EnrollmentParams.ValidityYears is now read and takes precedence over ValidityDays/SubscriptionValidityYears when building the order request. Previously declared as an enrollment param but never consumed. - Issue 0007: when DCV is enabled but no IDomainValidatorFactory is wired, the enrollment result now surfaces the exact TXT record name/value the operator needs to publish manually, instead of leaving the order pending with only a log line. - Issue 0006: PerformDcvIfNeededAsync can now follow CNAME delegation for the DCV challenge hostname (bounded depth, loop-detected via DnsClient.NET, resolving against OS-configured resolvers) and route both the TXT record target and the DNS-provider lookup to the terminal name. Gated behind new DcvFollowCnameDelegation config flag, default off/unchanged behavior.
Exercises the production DnsClient.NET-backed CnameResolver directly against real Cloudflare-hosted DNS records (creating/cleaning up temporary CNAME records via the same API pattern as CloudflareDomainValidator), independent of CERTInext order placement — confirms real two-hop CNAME chasing and the no-CNAME/terminal-on-first-hop case actually work over the network, not just the fake-delegate unit tests.
spbsoluble
changed the title
Covers the net10.0-only/DcvSupport-default-true build change plus the ValidityYears fix, manual DCV guidance, and CNAME-delegation support added on top of it in this PR.
Local working notes, not meant for the repo.
Drop the Build section's internal package/version detail and fold the .NET 8 removal into Chores, framed around the actual customer-facing reason: DCV requires Command 26.2+, which requires .NET 10+.
Replaces make with just as the command runner for build/test/API smoke-test targets, and updates every doc/script reference from `make` to `just` accordingly. README.md regenerated from docsource to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
-p:DcvSupport=falseinstead to get the compatible, no-DCV build.ValidityYearsenrollment setting is now honored — previously it had no effect. (ValidityYearstemplate enrollment parameter is a silent no-op #14)DcvFollowCnameDelegationsetting. (No CNAME-delegation support in DCV (validation zone must equal the domain) #15)Makefilewith ajustfilefor build/test/API smoke-test targets. No functional change for gateway/Command — contributor-facing only.Upgrade notes
-p:DcvSupport=false.Closes #14, #15, #16.