Skip to content

fix for updated imgui. #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpx1000 merged 1 commit into from
Jul 7, 2026
Merged

fix for updated imgui. #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions attachments/sync2_engine/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ set(SOURCES_COMMON
imgui_system.cpp
${SIMPLE_ENGINE_DIR}/imgui/imgui.cpp
${SIMPLE_ENGINE_DIR}/imgui/imgui_draw.cpp
${SIMPLE_ENGINE_DIR}/imgui/imgui_tables.cpp
${SIMPLE_ENGINE_DIR}/imgui/imgui_widgets.cpp
${SIMPLE_ENGINE_DIR}/vulkan_device.cpp
pipeline.cpp
${SIMPLE_ENGINE_DIR}/descriptor_manager.cpp
Expand Down
34 changes: 19 additions & 15 deletions attachments/sync2_engine/imgui_system.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,13 +548,23 @@ void ImGuiSystem::HandleMouse(float x, float y, uint32_t buttons) {

ImGuiIO& io = ImGui::GetIO();

// Update mouse position
io.MousePos = ImVec2(x, y);
// Update mouse position (v1.87+ event API)
io.AddMousePosEvent(x, y);

// Update mouse buttons (v1.87+ event API)
// We compare with current state to send events only on change
static uint32_t lastButtons = 0;
if ((buttons & 0x01) != (lastButtons & 0x01)) {
io.AddMouseButtonEvent(0, (buttons & 0x01) != 0);
}
if ((buttons & 0x02) != (lastButtons & 0x02)) {
io.AddMouseButtonEvent(1, (buttons & 0x02) != 0);
}
if ((buttons & 0x04) != (lastButtons & 0x04)) {
io.AddMouseButtonEvent(2, (buttons & 0x04) != 0);
}

// Update mouse buttons
io.MouseDown[0] = (buttons & 0x01) != 0; // Left button
io.MouseDown[1] = (buttons & 0x02) != 0; // Right button
io.MouseDown[2] = (buttons & 0x04) != 0; // Middle button
lastButtons = buttons;
}

void ImGuiSystem::HandleKeyboard(uint32_t key, bool pressed) {
Expand All @@ -564,17 +574,11 @@ void ImGuiSystem::HandleKeyboard(uint32_t key, bool pressed) {

ImGuiIO& io = ImGui::GetIO();

// Update key state
// Update key state (v1.87+ event API)
// GLFW key codes are compatible with ImGuiKey values in modern ImGui backends
if (key < 512) {
io.KeysDown[key] = pressed;
io.AddKeyEvent((ImGuiKey)key, pressed);
}

// Update modifier keys
// Using GLFW key codes instead of Windows-specific VK_* constants
io.KeyCtrl = io.KeysDown[341] || io.KeysDown[345]; // Left/Right Control
io.KeyShift = io.KeysDown[340] || io.KeysDown[344]; // Left/Right Shift
io.KeyAlt = io.KeysDown[342] || io.KeysDown[346]; // Left/Right Alt
io.KeySuper = io.KeysDown[343] || io.KeysDown[347]; // Left/Right Super
}

void ImGuiSystem::HandleChar(uint32_t c) {
Expand Down
Loading