Repository navigation
Avoid shifting by 32 or more in interpretDFD - #32
Merged
Merged
Conversation
The BITLENGTH field holds the bit length minus 1, so 1U << BITLENGTH is undefined for samples of 32 bits or more, such as those of the R64 integer formats and block-compressed formats. Clamp the bit length to 32. The spec's extension of sampleUpper for longer samples gives the same result as comparing at 32 bits. Found by fuzzing KTX-Software with libFuzzer. Fixes KhronosGroup#31.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BITLENGTH field holds the bit length minus 1, so 1U << BITLENGTH is undefined for samples of 32 bits or more, such as those of the R64 integer formats and block-compressed formats.
Clamp the bit length to 32. The spec's extension of sampleUpper for longer samples gives the same result as comparing at 32 bits.
Found by fuzzing KTX-Software with libFuzzer. Fixes #31.