Repository navigation
Reject incomplete filters - #4235
Merged
josephsnyder merged 1 commit intoNov 16, 2026
Merged
josephsnyder merged 1 commit into
josephsnyder merged 1 commit into
Conversation
Before, if a request gave only some of a filter's `field`, `compare` and `value` parameters, the filter was silently dropped. When it was the only filter, the default match-all filter took its place. On queryTests, which has no row limit by default, a URL like `?filtercount=1&value1=foo` returned every test for the day and could run out of memory on large projects. An incomplete filter inside a block returned a 500 instead. The shared filter parser now returns a 400 that names the missing parameters. A filter with none of its parameters is still ignored, because the filter panels count empty blocks without sending them. New tests in `QueryTestsPageFiltersTest` cover both cases.
josephsnyder
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, if a request gave only some of a filter's
field,compareandvalueparameters, the filter was silently dropped. When it was the only filter, the default match-all filter took its place. On queryTests, which has no row limit by default, a URL like?filtercount=1&value1=fooreturned every test for the day and could run out of memory on large projects. An incomplete filter inside a block returned a 500 instead.The shared filter parser now returns a 400 that names the missing parameters. A filter with none of its parameters is still ignored, because the filter panels count empty blocks without sending them. New tests in
QueryTestsPageFiltersTestcover both cases.