fix(tools): pick the annotation under the press position - #930
Merged
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
annotation-select-press-pick
branch
from
August 27, 2026 18:43
7471ba1 to
2dce742
Compare
getSelectedData returns the widget manager's standing pick, resolved by its last tracked mouse move. That pick is empty while a buffer capture is in flight, and it sits at the coordinates of that move rather than the press, so a press could select an annotation the pointer had left or clear the selection instead of making one. A move that vtk.js reports as StartMouseMove is not tracked at all, so the pointer can leave an annotation while the pick stays on it. Resolve the pick at the press coordinates instead. The handler becomes async, which leaves propagation unchanged since only a return of EVENT_ABORT counts as handled. This also settles the macOS E2E failures in delete-selected-annotation.e2e.ts, where a press that lands on a stale empty pick never recovers: the retry presses at the position the pointer already holds, so no further move is dispatched and no new pick is resolved.
PaulHax
force-pushed
the
annotation-select-press-pick
branch
from
August 27, 2026 19:20
2dce742 to
c71c0e2
Compare
PaulHax
enabled auto-merge
August 27, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selection read the widget manager's standing pick, which is whatever its last tracked mouse move resolved. Pick at the press coordinates instead.
E2E covers it, with a control case that passes on main so the new test is known to discriminate.