fix(docs): Diagramme über Kroki rendern und inline einbetten - #2
Merged
Merged
Conversation
The published microsite showed no diagrams. The pages reference ./images/<name>.svg, which resolves to output/<folder>/images/, but asciidoctor-diagram writes generated images to the site root, output/images/ - so every diagram was a 404. Switch rendering to a Kroki server, as requested, so neither a developer machine nor the CI runner needs a local PlantUML or Graphviz. Kroki alone does not fix the broken links though: it changes who renders a diagram, not where the result is written. Therefore mark all eleven diagram blocks opts=inline. The SVG is embedded in the HTML, no file is written, and the path mismatch disappears. Verified: eight inline SVGs in the architecture document and three in the specification, in both generateSite and generateHTML output; no img reference to an .svg file remains anywhere in the site. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014S4btgSH36ViayKLqGLd6G
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Das Problem
Die Pages sind live, zeigen aber keine Diagramme. Ursache ist ein Pfad-Mismatch, kein Renderer-Fehler:
Jedes Diagramm war ein 404.
Was Kroki löst — und was nicht
Kroki ist eingebaut wie gewünscht (
asciidoctorAttributesmitdiagram-server-urlunddiagram-server-type: kroki_io). Damit braucht weder ein Entwicklerrechner noch der CI-Runner ein lokales PlantUML oder Graphviz.Die kaputten Links behebt Kroki aber nicht. Nachgemessen: Kroki entscheidet, wer rendert, nicht wohin das Ergebnis geschrieben wird. asciidoctor-diagram legt die Antwort des Servers weiterhin als lokale Datei ab, an derselben falschen Stelle:
generateSite: 8 inline-SVG in arc42-arc42-generator.html, 3 in use-cases-…
generateHTML: 8 inline-SVG, 0 Warnungen
Seiten mit verbleibender
<img …*.svg>-Referenz: keine