feat(TE-16223): hide internal unknown-branch sentinel and harden git info parsing - #553
Open
shrinishLT wants to merge 1 commit into
Open
feat(TE-16223): hide internal unknown-branch sentinel and harden git info parsing#553shrinishLT wants to merge 1 commit into
shrinishLT wants to merge 1 commit into
Conversation
…info parsing Builds on managed-baseline (single_baseline) omni projects carry the internal unknown-branch sentinel; suppress it in the results summary, omni header, and saved results file instead of showing it to users. Also hardens file-based git info against a missing commit_id, which previously crashed the whole run with a TypeError. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI side of TE-16223 (SmartUI Managed Baseline for omni projects). The CLI needs almost nothing for the new mode — git is already optional client-side and
--markBaselineis already sent in the build payload — so this PR is just the two user-facing cleanups:unknown-branch: it's an internal sentinel for git-less builds. The results summary, omni header, and saved results file (branchName) now omit the branch when it's empty or the sentinel (displayBranchNamehelper).SMARTUI_GIT_INFO_FILEPATH) with a missingcommit_idthrew a TypeError that killed the whole run; now falls back to an empty commit id.Companion PRs: DES LambdatestIncPrivate/dotlapse-event-service#2828 · LSRS LambdatestIncPrivate/smartui-rendering-service#1243
Verified:
tsupbuild clean;tsc --noEmitshows no errors in touched files (the single tsconfig TS5110 error is pre-existing on stage).🤖 Generated with Claude Code