security: durable wallet LMDB and non-root Docker image - #129
Open
ekulkisnek wants to merge 1 commit into
Open
Conversation
- Drop NO_SYNC/NO_META_SYNC/MAP_ASYNC on the wallet env so seed/UTXO commits are fsynced (chain state can be rebuilt; the wallet seed cannot) - chmod 0700 the wallet data directory on Unix - Run the container as uid/gid 1000 (thunder) instead of root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves wallet durability and container safety: wallet seed/UTXO data should be fsynced (unlike rebuildable chain state), and the image should not run as root.
Changes
NO_SYNC/NO_META_SYNC/MAP_ASYNCon the wallet LMDB env so seed/UTXO commits are fsyncedchmod 0700the wallet data directory on Unixthunder) instead of rootTest plan