fix(cli): --input-csv silently ignores --min-savings-pct and --max-break-even-months #1819

--min-savings-pct and --max-break-even-months are accepted on --input-csv runs and have no effect. Nothing tells the operator they were ignored. This is the same silence defect as #1741, in the same function, on the two threshold flags #1741 did not cover.

Why #1741's fix does not reach them

#1741 routes the CSV path through scorer.Score so --min-count and savings-ordered capping behave the same on both paths. It deliberately passes only MinCount:

scored := scorer.Score(recs, scorer.Config{MinCount: cfg.MinCount})

Passing the other two would be worse than passing nothing. The CSV format carries neither figure: writeMultiServiceCSVReport emits no savings-percentage and no break-even column, and parseCSVRecord reads neither, so SavingsPercentage and BreakEvenMonths both load as 0 on every row. scorer.filterReason gates with rec.SavingsPercentage < cfg.MinSavingsPct, so a non-zero --min-savings-pct against a uniformly-zero field rejects every row of every file. A silent no-op would become a silent empty run.

Note the ordering consequence, already relied on by #1741: because SavingsPercentage is uniformly zero on loaded rows, scorer.Score's sort resolves on its secondary key, EstimatedSavings descending. That is the savings signal a CSV does carry, and it is what makes savings-ordered capping meaningful on this path. Any fix that starts populating SavingsPercentage must keep that ordering correct rather than silently re-ranking on a newly-populated field.

The two ends

Same shape as #1741's framing, and the choice should be made before implementing:

• Carry the data. Add savings-percentage and break-even columns to writeMultiServiceCSVReport, read them in parseCSVRecord, and hand all three thresholds to the scorer. Needs a decision on rows from older reports that lack the columns: a missing figure must be represented as absent, not coerced to 0, or the gates read "0% savings" and reject rows they were never meant to judge.
• Refuse the flags. If CSV mode is not meant to re-litigate quality thresholds, error out when either flag is combined with --input-csv, rather than accepting and ignoring it.

Do not split the difference, and do not fix the silence with different silence.

Scope note

docs/cli/filtering.md documents both flags as flags of the tool, not of a mode, exactly as it does for the two flags #1741 covers. Whichever end is chosen, that page needs to match.

filterAndAdjustRecommendations sits under the gocyclo ceiling tracked in LeanerCloud/cloud-commitments-platform#163 (it is at 8 after #1741's extraction), so there is some headroom, but not much.

Related

• fix(cli): --input-csv enforces neither --min-count nor savings-ordered capping, silently #1741 — --min-count and savings-ordered capping on the same path. Fixed; this issue is the explicitly deferred remainder.
• #1719 — the gocyclo ceiling on this function.
• fix(cli): the --input-csv purchase path writes no audit records and skips the writability pre-check #1609, fix(cli): CSV-mode purchase confirmation is per-region and declining does not abort the run #1610 — other live defects in filterAndAdjustRecommendations / runToolFromCSV.