Skip to content

chore(cli): delete the unused processService/processRegionRecommendations purchase path (no confirmation since #2105) #2110

Closed

Description

@cristim

Found in the review of #2105. cmd/multi_service_helpers.go ~431: the legacy processService -> processRegionRecommendations path relied on processPurchaseLoop's per-region confirmation, which #2105 removed in favour of a single up-front confirmPurchaseRun. The path has no production caller (tests only), so this is latent, but if anything calls it again it would purchase with no confirmation. Delete it (and its tests), or route it through confirmPurchaseRun. Also consider: the #2105 test covers only decline/non-TTY; add a SkipConfirmation=true multi-region case asserting totals.

Activity

  1. self-assigned this
    on Oct 17, 2026
  2. cristim commented on Oct 17, 2026

    @cristim
    MemberAuthor

    Claiming: working on this [claude-cli-impl]

  3. added a commit that references this issue on Oct 17, 2026
    ee2b597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions