Skip to content

test(cli): harden the GCP key cleanup from #2112 (assert no remote delete on local-unlink failure; panic path) #2117

Closed

Description

@cristim

From the review of #2112 (closes #1947):

  1. configure_gcp_test.go RemovalFailureReported doesn't assert !m.deleteCalled. A mutation that moves the remote-delete check after local removal (deleting a successfully stored key when the unlink fails) passes every test. Add assert.False(t, m.deleteCalled).
  2. A panic inside the upload skips the remote delete (the named err is still nil). Recover, or set err in a deferred recover.
  3. A second Ctrl-C during the 60s remote delete is swallowed (stop() is deferred).
  4. Pre-existing: an interrupt during the CreateKey RPC can exit with the key already minted in GCP.

Activity

  1. added
    priority/p3Polish / idea / may never ship
    effort/xsTrivial / one-liner
    type/choreMaintenance / non-user-visible
    on Sep 28, 2026
  2. self-assigned this
    on Oct 16, 2026
  3. cristim commented on Oct 16, 2026

    @cristim
    MemberAuthor

    Claiming: working on this [claude-cli-impl]

  4. added a commit that references this issue on Oct 16, 2026
    13dd607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions