You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(cli): harden the GCP key cleanup from #2112 (assert no remote delete on local-unlink failure; panic path) #2117
configure_gcp_test.go RemovalFailureReported doesn't assert !m.deleteCalled. A mutation that moves the remote-delete check after local removal (deleting a successfully stored key when the unlink fails) passes every test. Add assert.False(t, m.deleteCalled).
A panic inside the upload skips the remote delete (the named err is still nil). Recover, or set err in a deferred recover.
A second Ctrl-C during the 60s remote delete is swallowed (stop() is deferred).
Pre-existing: an interrupt during the CreateKey RPC can exit with the key already minted in GCP.
Activity
cristim commentedon Oct 16, 2026
Claiming: working on this [claude-cli-impl]
fix(cli): delete the minted GCP key when the credentials upload panics (
fix(cli): let a second Ctrl-C abort the GCP key cleanup (#2240)
fix(cli): warn that a GCP key may exist when CreateKey fails ambiguously
fix(cli): warn that a GCP key may exist when CreateKey fails ambiguously
fix(cli): warn that a GCP key may exist when CreateKey fails ambiguou…