Skip to content

fix(cmd): dry run accepts an EC2 Instance Savings Plan the real run refuses when InstanceFamily is unset #2164

Description

@cristim

validatePurchasePreconditions (added in #2160) requires only Details.Region for an EC2 Instance Savings Plan. With InstanceFamily unset and OfferingID empty, the real run can refuse in lookupEC2OfferingIDStrict (savingsplans/client.go:529-543: ambiguous or no offerings) while the dry run reports success. Require InstanceFamily unless OfferingID is set. Note the recommendation-completeness test fixture has no family and will need one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions