Skip to content

chore(deps): pin cloud-commitments-go/pkg to 73d3366 for pkg/insurance - #2159

Merged
cristim merged 1 commit into
mainfrom
chore/2156-pin-pkg-insurance
Oct 9, 2026
Merged

cristim merged 1 commit into
mainfrom
chore/2156-pin-pkg-insurance

Conversation

@cristim

@cristim cristim commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Pins cloud-commitments-go/pkg to exactly 73d3366 (go#285, adds pkg/insurance) for the Archera comparison command (#2156). One-line go.mod change; providers/* untouched (MVS selects 73d3366 for them). Later pkg commits are deliberately not taken: they bring the #306 recfilter behaviour change.

Evidence (same machine, GOWORK=off, go1.26.9)

go vet ./... go build ./... go test ./cmd
baseline (3d42b42) clean ok ok 457.8s
bumped clean ok ok 522.5s

Refs #2156

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated supporting components. No changes to end-user features or app behavior.

Pins pkg exactly at the commit that adds pkg/insurance (go#285) so the
Archera comparison command (#2156) can import it. providers/* are
unchanged; MVS selects 73d3366 for them. Later pkg commits are
deliberately not taken (they carry recfilter behaviour changes).

Refs #2156

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@cristim cristim added triaged Item has been triaged priority/p2 Backlog-worthy severity/medium Moderate harm urgency/this-sprint Within the current sprint impact/few Limited audience effort/m Days type/feat New capability labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 63ea5d47-355c-491b-bead-481f36e13213

📥 Commits

Reviewing files that changed from the base of the PR and between fa33d94 and 791cb87.


⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)
  • go.mod

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.



📝 Walkthrough

Walkthrough

The go.mod file updates the github.com/LeanerCloud/cloud-commitments-go/pkg dependency to a new pseudo-version.

Changes

Dependency version update

Layer / File(s) Summary
Update dependency version
go.mod
The cloud-commitments-go/pkg dependency changes from v0.0.0-20261006104817-90e61e668b99 to v0.0.0-20261008151559-73d3366903bc.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 791cb

The update adds insurance support; the other observed dependency changes are not used by this CLI. No concrete behavior change warrants delaying merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the dependency update and the affected pkg/insurance package. It matches the one-line go.mod change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

Gate verdict (cli gate-1, independent adversarial review, claude-opus-5-5): APPROVE at 791cb8757a13bf5e6f8658a8f7911a87161c484f

  • Pin: 73d3366 is on cloud-commitments-go main; pseudo-version time 20261008151559 matches its UTC commit time; 90e61e66 is an ancestor (forward move). go.mod -1/+1, go.sum -2/+2, no replace directives, go mod tidy -diff clean, go mod verify ok. MVS selects 73d3366 while providers aws/azure/gcp still require 90e61e66.
  • pkg/ range 90e61e66..73d3366 (fresh clone): 07d8b1f (optional GCPCommitmentType on ComputeDetails, omitempty, never set by the CLI or pinned providers), a9a4262 + 9c5b6f7 (exchange: RIExchangeStore.ReserveRIExchange, RunAutoExchange rework), 73d3366 (new pkg/insurance). No recfilter change. No RIExchangeStore implementer in the CLI or pinned providers; the only RunAutoExchange caller (providers/aws ladder/reshape.go:96) is not reachable from the CLI (no ladder or auto-exchange imports).
  • Local (git archive, GOWORK=off, go1.26.9, macOS): vet + go build -o /dev/null ./... ok on baseline 3d42b42 and head; go test -timeout 20m ./cmd/... baseline ok 447.3s, bumped ok 449.1s (the CLI has no ./pkg packages). The bump on current main (with fix(gcp): provision Recommender list permission in the setup wizard #2158): tidy, vet, build and TestGCPStepGrantRole pass.
  • CI green at this SHA, mergeStateStatus CLEAN. No findings. CodeRabbit not required: independent review plus local verification at the exact revision.

@cristim
cristim merged commit 22126ab into main Oct 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/few Limited audience priority/p2 Backlog-worthy severity/medium Moderate harm triaged Item has been triaged type/feat New capability urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant