Repository navigation
feat(aws): retain checked commitment payment currency #418
Description
Summary: populate the already published Recommendation.CommitmentCurrency contract from AWS Cost Explorer recommendation sources when the payment currency is actually established.
Current behavior: AWS RI and Savings Plans parsers omit the field. A consumer cannot tell the denomination of commitment and recurring payment amounts even when the source supplied the required currency and payment legs. The shared contract already shipped in #409/#410.
Steps to verify: exercise the actual Cost Explorer SDK recommendation client with constructed non-USD RI and Savings Plans responses, then inspect the resulting public Recommendation, shared scaling/resize operations and JSON. Check no-upfront, partial-upfront and all-upfront; missing currency or required source legs; known zeros; contradictory and malformed amounts. This proof uses synthetic fixtures, not live billing data.
Expected behavior: retain the source currency only for complete payment-leg evidence. Unknown and incomplete data remain unknown. Existing amounts, savings/baseline currency and payment validation remain unchanged.
Proposed fix: update providers/aws/recommendations/parser_ri.go and parser_sp.go, select the published shared module defining the field in AWS go.mod/go.sum, and add an external-package producer/consumer SDK fixture. Keep the leaf AWS-only, at most 400 changed lines, with native verification, independent review, replacement-free published-provider natural-MVS proof and required Linux CI. Platform pin/adoption remains part of #124 and is not included.
References: #124, #409, #410, and the separately shipped GCP leaf #411/#412.
Severity: medium, missing payment denomination metadata. Priority: P2, this sprint. Impact: provider library consumers. Effort: small.
Activity
cristim commentedon Oct 15, 2026
Merged #419 as
740dfbd72456a4a0b4cba3152a90d9be85abd1fe; its tree exactly equals reviewed8628011aa5d6b055c8c9ec295110d860b8a59c01. #418 was closed automatically by the scoped closing reference.Verified the public AWS SDK producer through an external consumer initially requiring only AWS
v0.0.0-20261015143912-740dfbd72456. Tidy naturally selected sharedv0.0.0-20261015085730-498b74f31f01; the entire module graph has no replacements. The committed SDK fixture hash matched, and fresh macOS Go1.26.9 race tests passed through required payment legs, non-USD/unknown currency, Scale/Resize and JSON.Both actual post-merge workflows completed successfully:
The fresh independent review completed two adversarial passes on the exact pre-merge head. Its old-parser regression and required-leg mutation compiled, failed the intended runtime assertions, and passed after restoration. The merged tree is identical. The separate first-attempt external schema-download failure was resolved by one bounded failed-job retry without changing source or workflow checks; #420 tracks the recurring CI dependency issue.
This is synthetic SDK fixture evidence, not a recorded AWS economic response. No real cloud call, purchase, deployment, platform module update or savings/baseline currency relabeling occurred. The AWS producer leaf is verified; the broader platform adoption work remains in #124.
Follow-up issues filed: #420.