Repository navigation
fix(aws): expose rate interface through shared minimum - #405
Conversation
Raise the shared module minimum so AWS-only consumers can use the new optional commitment-rate interface after normal dependency resolution.
|
@coderabbitai review |
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Independent retained adversarial review: no remaining actionable findings after two passes on head Pass 1 checked the complete two-file diff, minimum-version selection, checksums and compatibility. Pass 2 attacked the real installation path, scope and reuse: the diff changes only The dependency finding is independently reproduced and closed. A fresh consumer that initially required only published AWS Fresh macOS proof with
These are constructed SDK HTTP loopback fixtures, not live AWS billing acceptance. No real AWS API, purchase, deployment or execution enablement occurred. The verdict covers this exact head; actual CI, normal merge authorization, and the resulting parent #404 head still require their own checks. |
|
Merge evidence for head
CodeRabbit's green status is not a completed review: it posted “Review rate limited” and separately skipped automatic review on this non-default target branch. The exact independent proof above satisfies the repository's optional-review policy. CR waived: quota, adversarial review + local verification + green CI This merges only into #404's feature branch. That PR's resulting head still needs its own exact-revision review and required main-target CI. No purchase, deployment or execution enablement is included. |
Installing the AWS module from #404 alone selected a shared module version without
CommitmentRateCapability. A clean consumer importing that interface failed to compile even aftergo mod tidymade the shared dependency direct. Raise the AWS minimum to the already published shared candidate so the normal installation path exposes the interface.This stacked correction targets #404 and changes only the AWS dependency manifest and checksums. Runtime source, tests, EC2-only scope and Compute Holds are unchanged. Refs #349.
Verification: independent consumer compilation failed before the version correction and passed afterward; standalone AWS build and focused ladder race tests passed on macOS with Go 1.26.9 and
GOWORK=off. The full prior standalone race suite covered the unchanged implementation. Two retained independent review passes cover treeba207c320b43c40492968a6714c333f50f22763c, and all normal commit hooks passed. Published replacement-free consumer verification, committed-head review and actual CI remain merge gates.