Skip to content

docs(claude): PR-search limit and shared-login release in the claim rules - #76

Merged
cristim merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:docs/claude-md-claim-followup
Oct 16, 2026
Merged

cristim merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:docs/claude-md-claim-followup

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #62. That PR merged with an earlier revision of the "Issue assignment — claim before you work" section, before the last two review refinements landed in LeanerCloud/cloud-commitments-cli#2202 and LeanerCloud/cloud-commitments-go#421. This PR brings this repo's copy in line with them.

Changes (CLAUDE.md only, +10/-2):

  1. Step 1: the open-PR check is now gh pr list ... --limit 1000 --search "<issue number> in:body", with the same "split it if it returns 1000" note as the issue queries. gh pr list defaults to 30 results, so a PR covering the issue could be missed.
  2. Step 2: skip --remove-assignee when another worker on your shared login still holds an active claim, because the assignment is that worker's too.
  3. Step 5: the same exception on release.

Your priority-order text from the later docs PR in this repo is kept as is. cli#2202 and go#421 don't have it yet. After a normalized diff (repo name substituted), this repo's section differs from cli#2202 only in that paragraph.

Verification: markdownlint v0.47.0, the version pinned in .pre-commit-config.yaml, with the repo config: clean. No trailing whitespace. Docs only; no code or workflow changes.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • The issue-claim workflow can now find up to 1,000 open pull requests.
    • Clarified that releasing or declining an issue should not remove a shared assignment held by another worker using the same login.

…ules

Bring the issue-assignment section in line with the final wording in
cloud-commitments-cli#2202 and cloud-commitments-go#421: cap the open-PR
search at --limit 1000 (split if it returns 1000), and keep a shared-login
assignment when another worker on that login still holds an active claim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e747ebd9-0d14-4159-a5dd-3a9d3fb6f1f5
📥 Commits

Reviewing files that changed from the base of the PR and between fae9b5d and 00f51d0.

📒 Files selected for processing: 1
  • CLAUDE.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The issue-claim workflow now requests up to 1,000 open-PR search results. Its instructions also say to keep an issue assigned when another worker on the shared login still holds an active claim.

Changes: Issue Claim Workflow

Layer / File(s) Summary
Open-PR search limit
CLAUDE.md
The open-PR search command now sets a limit of 1,000 results.
Shared-login assignment handling
CLAUDE.md
The unassignment and release instructions now say to leave the issue assigned when another worker on the shared login has an active claim.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: cristim

Merge Risk: ⚪ Minimal · up to 00f51

The updated instructions bound the open-PR search and retain assignments for active shared-login claims. No actionable merge risk remains.

### Architecture Summary

Architecture risk: 🔵 Low · up to 00f51

The change affects 1 system.

Changed systems: CLAUDE.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CLAUDE.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CLAUDE.md: The open-PR search now sets a 1,000-result limit; the previous command had no explicit limit.
  • observed — Modified behavior in CLAUDE.md: Adds an exception to the unassignment instructions: skip removing the assignee when another worker on the shared login still holds an active claim.
  • observed — Modified behavior in CLAUDE.md: The release instructions now say to leave the assignment in place when another worker on the shared login still holds an active claim; previously they instructed unassignment without that exception.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies both documentation changes: increasing the PR search limit and preserving shared-login assignments during issue release.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@IAmJSD
IAmJSD marked this pull request as ready for review October 16, 2026 11:18

@cristim cristim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review verdict: CLEAN at 00f51d0

Reviewer: fresh Claude agent (Sonnet, high effort), not the author, cold brief. The PR body was treated as a claim. Coordinator: claude-cc-reviewer. The same review covered platform#966 and mcp#76, which carry the same change.

Blocking findings: none.

Non-blocking notes:

  • The step 2 shared-login exception has a narrow race. Two workers on one login who release at the same moment can each see the other's claim as active, so neither unassigns. The marker comments still show the issue as free, and step 3's 7-day staleness rule covers it.
  • "Active claim" is not restated in step 5. Step 2 already defines it.

What was attacked and how (docs-only change):

  • Normalized comparison: the "Issue assignment" section from this PR's head was compared with cli#2202 (73f4f520) and go#421 (4caefc35), with repo names replaced by REPO.
    • cli and go are byte-identical after normalization.
    • This PR differs from them only in its own step 1 priority-order paragraph, which the body says is kept on purpose.
    • The --limit 1000 change, the "split it the same way" note, the --remove-assignee skip and the step 5 exception are identical.
  • Command validity: gh pr list --limit 1000 --search "<n> in:body" is valid per gh pr list --help and was run live without error. "Split it the same way" refers to the created: date windows defined earlier in step 1.
  • Protocol coherence: the exception follows step 2's per-worker marker protocol. Release markers are still posted, so the last worker to leave unassigns, and no path leaves an issue assigned forever.
  • Diff hygiene: the diff is +10/-2. The only removed lines are the two that were replaced. List indentation and the code fence are intact.
  • Artifact checks: the pre-commit run, which includes the pinned markdownlint, is green at this SHA.

Gate: there is no linked issue (docs-only follow-up), so there are no labels to mirror. CodeRabbit is optional because a docs-only change plus this review covers the SHA. Merge waits on CI being green at this SHA.

@cristim
cristim merged commit 526ce1c into LeanerCloud:main Oct 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants