Skip to content

test(api): pin execution fixture to AWS credentials - #875

Merged
cristim merged 1 commit into
fix/631-ship-guarded-creatorfrom
fix/631-aws-execution-fixture
Oct 14, 2026
Merged

cristim merged 1 commit into
fix/631-ship-guarded-creatorfrom
fix/631-aws-execution-fixture

Conversation

@cristim

@cristim cristim commented Oct 14, 2026

Copy link
Copy Markdown
Member

The shared creator fixture now uses Azure, while the existing pause and run-now execution tests use AWS credentials and frozen AWS recommendations. Those tests fail credential resolution before reaching their recording provider.

Persist the specialized execution fixture's AWS identity and assert it after readback. Production credential resolution and the Azure creator proof stay unchanged.

Refs #631. Corrective dependency for #873.

Author verification at fd9771531dd22ae219b56f2ef0f9d2d296cd6f69: native PostgreSQL race suite covering shared fixture consumers and Azure manual/automatic recording-provider paths passed in 40.611s; API unit race passed in 43.629s; build, pinned integration lint and all normal commit hooks passed.

The retained independent verifier reviewed the full current diff twice without actionable findings and independently passed 33 native cases in 34.049s, with 40 fresh databases confirming migration 119. The exact parent-fixture overlay reproduced the real run-now Azure credential-dispatch error in 2.529s. The original six creator files remain byte-identical to the reviewed PR head.

This feature-target PR requires an explicit build/test workflow dispatch; local normal hooks provide the pre-commit evidence because that workflow does not trigger for feature targets. No live purchases or cloud mutations are involved. Real PostgreSQL, handler and store paths are exercised; authentication, credentials, email, execution clocks and the provider boundary use explicit fixtures.

@cristim cristim added effort/xl Multi-week / refactor impact/many Affects most users priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/feat New capability urgency/this-sprint Within the current sprint labels Oct 14, 2026
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: e8d2b2fb-a27c-4d4e-ae9d-124f56d2ec9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cristim

cristim commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

Independent review verdict: PASS at fd9771531dd22ae219b56f2ef0f9d2d296cd6f69, tree 1cabd2cbd3cb88e514d67d9aa01afeb1439e5a52, against main base a3bc552aaa85523ffbd96b2f865386bf662a440e. The owner-selected independent Sol medium verifier completed two adversarial passes over the full current change and found no actionable findings.

Independent native race verification passed 33 cases in 34.049s, including every shared fixture consumer, all pause/run-now cases, creator guards, nullable caps, SP policy and Azure manual/global-OFF plus automatic/global-ON recording-provider completion. Forty fresh databases confirmed migration 119. Replacing only the corrected fixture with its exact parent version reproduced the real Azure credential-dispatch error in 2.529s. Production credential resolution is unchanged.

Author native race passed in 40.611s, API unit race in 43.629s; build, pinned integration lint and all normal commit hooks passed. Handler/store/PostgreSQL paths are real; authentication, credentials, email, settings, clocks and the provider boundary use explicit fixtures. No live purchases or cloud mutations occurred.

CodeRabbit reports this feature target is skipped. The complete independent-review and local-verification path is used under the owner's authorization. Explicit build/test run 38651707238 covers this exact head and remains pending. Automatic Linux pre-commit does not run on this feature target; no such result is claimed. Normal merge waits for the dispatched workflow's full success and final live head/finding checks.

@cristim
cristim merged commit e25ae31 into fix/631-ship-guarded-creator Oct 14, 2026
24 checks passed
@cristim

cristim commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

Merged normally into the PR873 feature branch as e25ae316057f67162b6ff0c3e2164fa22ac20024 after dispatched build/test run38651707238 completed SUCCESS on exact reviewed fd9771531dd22ae219b56f2ef0f9d2d296cd6f69. Final live checks confirmed the expected source/target, MERGEABLE/CLEAN and no inline findings. No protections were bypassed.

The merged commit has the identical whole tree 1cabd2cbd3cb88e514d67d9aa01afeb1439e5a52. PR873 is still open and now runs its own normal required CI on that final head. This feature merge is not a main merge or deployment. Corrective CI and merge watchers have completed and were reaped; original refs, worktrees and proof artifacts remain preserved for the active #631 shipping task.

Follow-up issues filed: none; this correction and its remaining final-head gates are tracked by #631 and #873.

cristim added a commit that referenced this pull request Oct 14, 2026
* fix(api): restore guarded planned purchase creation

* fix(api): satisfy planned purchase lint checks

* test(api): pin execution fixture to AWS credentials (#875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xl Multi-week / refactor impact/many Affects most users priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/feat New capability urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant