Repository navigation
test(api): pin execution fixture to AWS credentials - #875
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Independent review verdict: PASS at Independent native race verification passed 33 cases in 34.049s, including every shared fixture consumer, all pause/run-now cases, creator guards, nullable caps, SP policy and Azure manual/global-OFF plus automatic/global-ON recording-provider completion. Forty fresh databases confirmed migration 119. Replacing only the corrected fixture with its exact parent version reproduced the real Azure credential-dispatch error in 2.529s. Production credential resolution is unchanged. Author native race passed in 40.611s, API unit race in 43.629s; build, pinned integration lint and all normal commit hooks passed. Handler/store/PostgreSQL paths are real; authentication, credentials, email, settings, clocks and the provider boundary use explicit fixtures. No live purchases or cloud mutations occurred. CodeRabbit reports this feature target is skipped. The complete independent-review and local-verification path is used under the owner's authorization. Explicit build/test run 38651707238 covers this exact head and remains pending. Automatic Linux pre-commit does not run on this feature target; no such result is claimed. Normal merge waits for the dispatched workflow's full success and final live head/finding checks. |
|
Merged normally into the PR873 feature branch as The merged commit has the identical whole tree Follow-up issues filed: none; this correction and its remaining final-head gates are tracked by #631 and #873. |
* fix(api): restore guarded planned purchase creation * fix(api): satisfy planned purchase lint checks * test(api): pin execution fixture to AWS credentials (#875)
The shared creator fixture now uses Azure, while the existing pause and run-now execution tests use AWS credentials and frozen AWS recommendations. Those tests fail credential resolution before reaching their recording provider.
Persist the specialized execution fixture's AWS identity and assert it after readback. Production credential resolution and the Azure creator proof stay unchanged.
Refs #631. Corrective dependency for #873.
Author verification at
fd9771531dd22ae219b56f2ef0f9d2d296cd6f69: native PostgreSQL race suite covering shared fixture consumers and Azure manual/automatic recording-provider paths passed in 40.611s; API unit race passed in 43.629s; build, pinned integration lint and all normal commit hooks passed.The retained independent verifier reviewed the full current diff twice without actionable findings and independently passed 33 native cases in 34.049s, with 40 fresh databases confirming migration 119. The exact parent-fixture overlay reproduced the real run-now Azure credential-dispatch error in 2.529s. The original six creator files remain byte-identical to the reviewed PR head.
This feature-target PR requires an explicit build/test workflow dispatch; local normal hooks provide the pre-commit evidence because that workflow does not trigger for feature targets. No live purchases or cloud mutations are involved. Real PostgreSQL, handler and store paths are exercised; authentication, credentials, email, execution clocks and the provider boundary use explicit fixtures.