Repository navigation
feat(plans): preview draft purchase schedules - #880
Conversation
Show a wide, keyboard-accessible target staircase without saving or scheduling purchases. Preserve the existing form and purchase actions. Refs #631
|
Independent exact-head review and verification covers Two retained adversarial source/staged passes and two fresh committed-head cold verification passes found no actionable findings. The original reviewed G1 patch and this transplant are byte-identical; the original branch and artifacts are preserved. Normal commit hooks passed. The cold verifier independently reproduced 223 affected Jest tests, typecheck, changed-source ESLint, an isolated production build, and Chromium scenarios at 1440, 1280, 390 and 320 pixels. The tests use the actual Create/Edit form, inspect keyboard/focus/inert/Escape behavior, exercise 100 points, and assert zero mutation requests or captured errors. Desktop and phone screenshots were inspected. The build has one existing entrypoint-size warning. Prior scratch probes each failed an assertion when the disclosure, keyboard behavior or no-write boundary was broken. Their transfer is supported by complete frontend/source and rebuilt-bundle byte identity; no unnecessary broad backend test rerun is claimed. Browser API/auth responses are fixtures. This leaf previews hypothetical dates and target shares, with unavailable amounts labeled honestly. It does not save schedules or display saved history or approval states. Existing purchase actions remain available while the atomic editor is developed. Owner-authorized independent |
|
Docstring coverage warning disposition: dismissed under the project’s comment conventions. The project uses descriptive names and types, with short comments for non-obvious reasons, and discourages docstrings that repeat a signature. The preset/custom-ramp policy mirror already identifies its cross-language source. CodeRabbit’s completed exact-head comment metadata reports no actionable comments or specific missing behavioral contract documentation. The inline-comment endpoint is empty. Independent triage agreed in two passes; no source change is needed for this generic coverage warning. |
|
PR #880 normally squash merged as All five post-merge workflows passed: full CI, automatic deployment, frontend E2E, frontend build sentinel and pre-commit. Every CI watcher and the completed PR merge watcher has been reaped. Read-only deployed identity verification returned HTTP200 from The actual Create/Edit form preview was independently verified locally from the production bundle at desktop and phone widths, including dense schedules, keyboard interaction, focus trapping and restoration, and zero API writes. The browser APIs/authentication were fixtures. This leaf adds the disclosed no-write preview; existing Save and Add Purchases actions remain. Atomic graph scheduling and saved history integration remain tracked in #631 and are not claimed complete by this PR. |
Add Preview schedule to the Create/Edit Purchase Plan form. It opens a wide target staircase with point selection, UTC dates, a compact summary and collapsed advanced settings. The dialog preserves form values and restores focus when closed.
The preview clearly labels its dates as hypothetical and shows unavailable amounts honestly. Existing Save and Add Purchases actions continue to serve scheduling while the atomic graph editor is developed. This leaf makes no API mutation and does not display saved purchase history.
Validation: 223 affected Jest tests, typecheck, changed-source ESLint and production webpack build. Production-bundle Chromium checks cover Create/Edit at 1440, 1280, 390 and 320 pixels, keyboard/focus behavior, 100 points and zero mutation requests. Browser APIs/auth are fixtures. Exact-head independent review and verification evidence is recorded separately on this PR.
Refs #631
Summary by CodeRabbit