Repository navigation
fix(governance): support signed CI rulesets and GitHub App-bound checks - #41
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…ion IDs Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Repository-only classic branch protection can conflict with the standard PR-only administrator bypass. The migration of
LibreCodeCoop/akaunting-mcppreserves its 14 required checks and required signatures in a ruleset, but the declarative governance engine cannot yet parse that rule and strips check integration IDs.Changes
required_signaturesas a managed ruleset rule.integration_idon required checks for GitHub App-specific context ownership.Verification
npm run check(typecheck, 63 Vitest tests, TypeScript build) passed.Follow-up
After this PR is merged and the
.githubworkflow pins the updated engine commit, the organization config PR can declare the existingakaunting-mcpCI-and-signature ruleset. Do not run privileged governance apply on the old engine version.