Repository navigation
fix(release): verify draft ancestry using remote branch history - #149
Merged
Merged
Conversation
The release branch can advance between workflow checkout and draft creation. Use the GitHub compare API to validate containment against the live branch without requiring its new head to be fetched locally. Reject divergent or unverifiable histories and cover the race with focused regression tests. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When
stable35advanced after the release preparation PR was merged but before its draft was created, the live branch HEAD referred to a commit unavailable in the workflow's earlier checkout.release:draftthen failed withfatal: Not a valid commit name ...during localgit merge-base --is-ancestor.Change
compare/base...headAPI pattern; retain strict rejection of divergent and unavailable histories.Validation
The original
LibreSign/libresignfinalization run #41893312671 was recovered by rerunning the failed jobs and completed successfully. Thev15.0.12draft was generated. This PR prevents recurrence; the source commit is cryptographically signed and DCO-compliant. CI remains the acceptance gate for the proposed release-tool change.No security advisory contents or private-fork details are included.