Harden and test ruleset synchronization - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the repository ruleset automation and add automated tests and CI checks.
Changes
nextcloud-botactor by its stable GitHub user ID--checkto report drift without modifying repositories--repo OWNER/REPOto safely target one repositorydocs/Security
Validation workflows do not receive the ruleset GitHub App credentials and run with read-only repository access.
The privileged workflow no longer creates one administration token with access to every repository in an organization. Repository discovery runs separately with the read-only workflow token, then each matrix job creates a short-lived GitHub App token scoped to exactly one repository with
administration: writeand runs the sync using--repo.Unexpected GitHub API errors while detecting
appinfo/info.xmlnow stop synchronization for that repository instead of treating it as a non-Nextcloud repository, preventing transient API or authorization failures from silently removing thenextcloud-botbypass.Testing
The Bats suite covers Nextcloud and non-Nextcloud repositories, unexpected API failures, bypass idempotency, repository targeting, API normalization and ruleset policy invariants.
CI checks are isolated by concern: