refactor: migrate controllers away from ValidateHelper

[vikas-kushwaha-dev]

Resolves: #8353

📝 Summary

Migrates the remaining simple controller consumers away from ValidateHelper and uses the focused validators directly.

• AccountController: removes the unused ValidateHelper dependency and import.
• FileController: replaces ValidateHelper with FileInputValidator for file validation and SigningRequestValidator for signing-request validation.
• PageController: replaces ValidateHelper with SigningRequestValidator and updates PageControllerTest accordingly.

This keeps the existing validation and signing-request behaviour unchanged while moving these controllers towards the dedicated validator classes.

No public API or UI behaviour is changed by this PR.

🧪 How to test

Run the affected controller tests:

php vendor/bin/phpunit -c tests/php/phpunit.xml --no-coverage tests/php/Unit/Controller/PageControllerTest.php
php vendor/bin/phpunit -c tests/php/phpunit.xml --no-coverage tests/php/Api/Controller/FileControllerTest.php
php vendor/bin/phpunit -c tests/php/phpunit.xml --no-coverage tests/php/Api/Controller/AccountControllerTest.php

The affected controller tests pass when run individually.

The complete unit test suite was also run locally. It completed all 3,860 tests, but the local devcontainer reported unrelated failures, primarily caused by Nextcloud appdata permission issues and API test state/authentication issues unrelated to this refactor.

Additional check:

git diff --check

passes without errors.

⚙️ API / Back-end changes

• Removed the unused ValidateHelper dependency from AccountController.
• Migrated FileController to focused validators.
• Migrated PageController to SigningRequestValidator.
• Updated the affected PageControllerTest.
• Existing signing-request behaviour preserved.
• No public API changes.
• No OpenAPI update required.

🚧 Backport

None (main only).

✅ Checklist

• I have read and followed the contribution guide.
• Changes are limited to the scope of Migrate remaining controller consumers away from ValidateHelper #8353.
• Existing controller behaviour is preserved.
• Affected controller tests pass individually.
• git diff --check passes.

🤖 AI (if applicable)

• The content of this PR was partially or fully generated using AI.

[welcome]

Thanks for opening your first pull request in this repository! ✌️

[vitormattos]

@vikas-kushwaha-dev could you check the DCO issue?
https://github.com/LibreSign/libresign/pull/8383/checks?check_run_id=103780628795

[vitormattos]

The php-cs check confirms that the new validator imports need to be reordered.

composer run cs:check reports the same issue in three files:

• lib/Controller/FileController.php
• lib/Controller/PageController.php
• tests/php/Unit/Controller/PageControllerTest.php

Could you please run composer run cs:fix and commit the resulting import ordering changes?

[vitormattos]

The code changes look good now. The import ordering issue is fixed.

There are two things left before this PR can be merged: the branch has a conflict with main, and the DCO check shows that the first commit is missing the required sign-off.

If you do not already have the LibreSign repository configured as upstream, you can add it with:

git remote add upstream https://github.com/LibreSign/libresign.git
git fetch upstream

Then rebase your branch on the current main and add the DCO sign-off to the commits:

git rebase --signoff upstream/main

If Git reports a conflict, resolve the conflicting files, then run:

git add <resolved-files>
git rebase --continue

Repeat this until the rebase finishes.

After that, update your PR branch with:

git push --force-with-lease origin refactor/8353-migrate-validate-helper

Please use --force-with-lease instead of --force, as it avoids overwriting unexpected remote changes.

LibreSign requires DCO sign-off on every commit. DCO (Developer Certificate of Origin) is a lightweight way to certify that you have the right to contribute the code under the project's license. Git records this with a line like:

Signed-off-by: Your Name <your@email>

Using git commit -s when creating commits adds this automatically. In this PR, your second commit already has the sign-off; the DCO check is reporting the first commit.

We also have this documented here:
https://github.com/LibreSign/documentation/blob/main/developer_manual/getting-started/commits.rst

More about DCO:
https://developercertificate.org/

After the rebase and push, GitHub should recalculate the conflict status and the DCO check.

[vikas-kushwaha-dev]

Hi @vitormattos, I’ve addressed the requested changes. The branch has been rebased, the commit history has been cleaned up, and the DCO check is now passing. Could you please re-review the PR and approve the pending workflows when you have a chance? Thanks!