test: use PSR container in InjectionMiddlewareTest - #8403
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
fix/nc36-server-container-test
branch
from
September 15, 2026 01:51
91e2ff8 to
0f36adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
InjectionMiddlewareTeston Nextcloud 36 after the removal of the deprecatedOCP\IServerContainerinterface.The test instantiated
OC\InitialStateServicewith a mock ofOCP\IServerContainer. Nextcloud 36 removed that interface, while the currentInitialStateServiceconstructor acceptsPsr\Container\ContainerInterface.This PR replaces the obsolete mock with
Psr\Container\ContainerInterface.A repository-wide search found no other
IServerContainerreferences in LibreSign.Why
The PHPUnit jobs fail with:
This is triggered by the Nextcloud 36 server change, not by application behavior.
Scope
main/ Nextcloud 36 compatibility.Validation
Expected to restore the failing
InjectionMiddlewareTestcases in the PHPUnit matrix on Nextcloud 36.