Conversation
The SignedCallbackListener checked a 'signed' field in the updated fields, but the File entity tracks the signature via signedNodeId and signedHash (set by SignFileService::updateLibreSignFile). Because 'signed' never exists, the callback URL was never notified after the document was signed. Check signedNodeId/signedHash instead so the webhook fires on signing. Signed-off-by: henmohr <henriquemohr@redes.ufsm.br>
henmohr
force-pushed
the
fix/signed-callback-listener
branch
from
September 15, 2026 13:27
e2f1906 to
c003a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The webhook/callback configured via the
callbackfield ofrequest-signaturewas never fired after the document was signed.Root cause
SignedCallbackListener::handle()checked for asignedkey in the entity's updated fields:However, the
Fileentity does not have asignedfield. The signature is tracked bysignedNodeIdandsignedHash, which are set inSignFileService::updateLibreSignFile()(viasetSignedNodeId/setSignedHash). As a result the condition was always false and the callback was never notified.Fix
Check
signedNodeId/signedHashinstead:Testing
Verified against Nextcloud 35 + LibreSign
stable35: after signing, the callback URL now receives the multipart POST (uuid, status, file) automatically. Previously it required a manual invocation of the callback endpoint.