[codex] apply dynamic contrast to text blocks#985
Open
chaochaoweb3 wants to merge 27 commits into
Open
Conversation
* Refactor * dependencies * Exclude dev dependencies
This reverts commit 67e5146.
production dependencies
Three link management endpoints accept user-supplied link IDs
without verifying ownership, allowing any authenticated user to
modify other users' links:
- POST /studio/edit-link (saveLink): add ownership check before update
- POST /studio/sort-link (sortLinks): add user_id where clause
- GET /clearIcon/{id}: add existing link-id middleware to route
Co-authored-by: aazad <ali.azad@yahooinc.com>
strip_tags() allows <a> tags but does not remove HTML attributes,
allowing event handlers like onmouseover to pass through. The
description is rendered unescaped via {!! !!} in linkinfo.blade.php,
enabling stored XSS.
Add regex filters using word boundary matching to strip all on* event
handler attributes (both quoted and unquoted values) from the sanitized
description before saving to the database.
Co-authored-by: aazad <ali.azad@yahooinc.com>
…g#970) The download link was generated as /admin/backups/?filename.zip but the download handler checks $_GET['file'], so the handler was never triggered. The browser navigated to the page instead of downloading the file, causing a JS error. Changed: url('admin/backups') . '/?' . $entry To: url('admin/backups') . '?file=' . $entry
chaochaoweb3
force-pushed
the
codex/fix-text-block-contrast
branch
from
bef6b06 to
51ce3c2
Compare
Contributor
Author
|
Rebased this onto the latest upstream main, corrected the commit author metadata, and marked it ready for review. I also triggered a fresh Scrutinizer run; it still reports repository-level analysis errored / tests failed with no artifacts exposed, and the Scrutinizer API shows the tracked main build is already failed. Local validation available here was git diff --check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #966.
Summary
Validation