Repository navigation
refactor(web): resolve active Sonar findings - #314
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 50.70% 50.70%
=======================================
Files 40 40
Lines 13259 13259
=======================================
Hits 6723 6723
Misses 6536 6536
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unnecessary
asyncfrom the playback controller's default refresh callback while preserving itsPromise<void>contract. Use HTTPS for the mock API's path-parsing base URL; mock dispatch still uses only the URL path and query and performs no network request.This addresses the complete active Sonar baseline on
master: onetypescript:S7503issue, plus the one unreviewedtypescript:S5332security hotspot. No issue statuses or suppressions were changed.Screenshot
Issues Fixed or Closed
Roadmap Issues
Testing
npm run check: passed.npm test: all 126 tests passed, including existing mock API coverage.npm run build: passed; existing chunk-size advisory remains.git diff --check: passed.No new regression tests were added because these two behavior-preserving substitutions add no functionality: the default callback still resolves to
undefined, and mock dispatch ignores the URL scheme. TypeScript validates the callback contract and the existing tests exercise mock dispatch. Rust code and dependencies are unchanged, so Rust checks were not run.Hosted Sonar analysis completed successfully for
7d1d1c43e0c773fc121baabb50e295a8dd442ef3: zero active PR issues, zero unreviewed PR security hotspots, and quality gateOK. Both Sonar checks passed. The targetmasterbranch is unchanged; whole-branch closure remains subject to analysis after merge.Type of Change
Checklist
AI Usage
See our AI usage policy.