test: gate tray test hooks behind build flag - #184
Merged
Conversation
Update the Linux-specific fallback menu anchor when only a bottom inset is detected. Instead of using the far-right edge, position the tray point at roughly three-quarters of the screen width to better match KDE Plasma’s default bottom panel layout, where the rightmost control is often “Peek at Desktop” rather than a tray icon.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 61.74% 61.62% -0.12%
==========================================
Files 5 5
Lines 515 516 +1
Branches 194 194
==========================================
Hits 318 318
- Misses 127 128 +1
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
|
Screenshot ComparisonPR #184 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: Linux-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: Windows-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Matrix: macOS-qt6
| Image | Baseline | PR |
|---|---|---|
tray_icon_ico.png |
 |
 |
tray_icon_initial.png |
 |
 |
tray_icon_png.png |
 |
 |
tray_icon_svg.png |
 |
 |
tray_icon_themed.png |
 |
 |
tray_icon_update_ico.png |
 |
 |
tray_icon_update_png.png |
 |
 |
tray_icon_update_svg.png |
 |
 |
tray_icon_update_themed.png |
 |
 |
tray_menu_checkbox_checked.png |
 |
 |
tray_menu_checkbox_unchecked.png |
 |
 |
tray_menu_left_click.png |
 |
 |
tray_menu_shown.png |
 |
 |
tray_notification_ico_icon.png |
 |
 |
tray_notification_png_icon.png |
 |
 |
tray_notification_svg_icon.png |
 |
 |
tray_notification_themed_icon.png |
 |
 |
tray_tooltip_hover.png |
 |
 |
Wraps mouse-position test helpers and related Qt/state code in `TRAY_ENABLE_TEST_HOOKS` so test-only APIs are excluded from normal builds. CMake now defines this flag for top-level test builds and for the test target, keeping production/library consumers free of test hooks while preserving test functionality.
ReenigneArcher
force-pushed
the
test/fix-tray-icon-position
branch
from
September 6, 2026 14:44
f04464d to
0ca2579
Compare
ReenigneArcher
changed the title
Extract tooltip wait logic into a dedicated `WaitForTooltipReady()` helper and use it in `TestTooltipDisplayOnHover`. This centralizes the asynchronous shell-tooltip delay handling and improves test readability and consistency.
ReenigneArcher
marked this pull request as ready for review
September 6, 2026 15:01
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wraps mouse-position test helpers and related Qt/state code in
TRAY_ENABLE_TEST_HOOKSso test-only APIs are excluded from normal builds. CMake now defines this flag for top-level test builds and for the test target, keeping production/library consumers free of test hooks while preserving test functionality.Also fixes mouse position for Linux tests (using plasma in CI).
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.