D062 — rebuild descriptor lifecycle around runtime identity - #98
D062 — rebuild descriptor lifecycle around runtime identity#98LogicDuke wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PeZ5wFfhzgCT5tL8NLkKNz
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PeZ5wFfhzgCT5tL8NLkKNz
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05371172c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // helper: owner, DACL present + protected, direct operator+SYSTEM only. | ||
| let acl: DescriptorAclVerification; | ||
| try { | ||
| acl = await verifyDescriptor(descriptorPath, { env }); |
There was a problem hiding this comment.
Keep the server inert until descriptor verification finishes
When the control CLI runs while verifyDescriptor or the subsequent read-back is pending, the descriptor has already been published and the pipe is already serving with the real dispatcher, so the CLI can discover the runtime, authenticate with the published token, and apply OPEN_HUMAN_GATE. If verification later rejects the descriptor, startControlChannel returns null, but the state-changing command has already run, defeating the intended fail-closed verification gate. Gate connection dispatch until both post-publication checks succeed, or otherwise prevent the published endpoint from handling commands during this interval.
Useful? React with 👍 / 👎.
Rebuilds the D062 runtime descriptor lifecycle from exact PR #84 HEAD after the prior fixed-path design was quarantined in closed PR #96.
Protected parent:
Rebuild head:
Architecture change:
Authority boundaries preserved:
Validated candidate:
Independent validation:
Prior quarantine:
This PR must remain Draft until exact-head CI and independent GitHub review evidence pass.
Human merge authority remains required.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PeZ5wFfhzgCT5tL8NLkKNz