Skip to content

D062 — rebuild descriptor lifecycle around runtime identity - #98

Draft
LogicDuke wants to merge 2 commits into
feature/d062-post-start-control-channelfrom
rebuild/pr84-descriptor-lifecycle-v2
Draft

D062 — rebuild descriptor lifecycle around runtime identity#98
LogicDuke wants to merge 2 commits into
feature/d062-post-start-control-channelfrom
rebuild/pr84-descriptor-lifecycle-v2

Conversation

@LogicDuke

Copy link
Copy Markdown
Owner

Rebuilds the D062 runtime descriptor lifecycle from exact PR #84 HEAD after the prior fixed-path design was quarantined in closed PR #96.

Protected parent:

Rebuild head:

  • branch: rebuild/pr84-descriptor-lifecycle-v2
  • exact commit: 78a5f03

Architecture change:

  • removes the shared mutable runtime-descriptor.json authority cell
  • uses per-runtime identity-named descriptors
  • listen before publish
  • CREATE_NEW native descriptor creation
  • exact-file ACL verification
  • identity-bound cleanup
  • pipe ENOENT as the only foreign-deletion deadness signal
  • bounded discovery
  • multiple live runtimes fail closed as ambiguous
  • Cockpit bind succeeds before control startup begins
  • no PID ownership
  • no lock / lease / polling
  • no repeated ownership recheck mechanism

Authority boundaries preserved:

  • AgentBridge V1 remains READ-ONLY against managed repositories
  • no shell
  • no PowerShell/cmd production transport
  • no runtime compiler authority
  • no generic ACL mutation authority
  • owner helper remains READ-ONLY
  • descriptor creator remains narrowly CREATE_ONLY
  • Cockpit remains read-only and independent from control startup failure

Validated candidate:

  • commit: 78a5f03
  • parent: 30fc85e
  • files: 21
  • patch SHA256: 0BEC7D6187730532147ED993108C9C090A8C7461ACF4D0AFE12BD90BBD54318E
  • patch bytes: 395736

Independent validation:

  • zero CURRENT findings
  • focused: 180/180
  • Windows real-native: 19/19
  • tests/control: 295 passed / 1 skipped
  • full suite: 2191 passed / 1 skipped
  • typecheck: PASS
  • lint: PASS
  • build: PASS
  • git diff --check: PASS

Prior quarantine:

This PR must remain Draft until exact-head CI and independent GitHub review evidence pass.

Human merge authority remains required.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PeZ5wFfhzgCT5tL8NLkKNz

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PeZ5wFfhzgCT5tL8NLkKNz
@LogicDuke

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T12:21:37.733942Z 0537117 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05371172c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// helper: owner, DACL present + protected, direct operator+SYSTEM only.
let acl: DescriptorAclVerification;
try {
acl = await verifyDescriptor(descriptorPath, { env });

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the server inert until descriptor verification finishes

When the control CLI runs while verifyDescriptor or the subsequent read-back is pending, the descriptor has already been published and the pipe is already serving with the real dispatcher, so the CLI can discover the runtime, authenticate with the published token, and apply OPEN_HUMAN_GATE. If verification later rejects the descriptor, startControlChannel returns null, but the state-changing command has already run, defeating the intended fail-closed verification gate. Gate connection dispatch until both post-publication checks succeed, or otherwise prevent the published endpoint from handling commands during this interval.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant