forked from built-fast/phpstan-sensitive-parameter
-
Notifications
You must be signed in to change notification settings - Fork 0
No flags on bool arguments #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b02bb06
First stab
ildyria 7de3622
fix
ildyria 83bab81
avoid flagging on bools and is-prefixed
ildyria fdfb2a7
Add two more rules
ildyria b61aa7b
correct branch
ildyria b640f71
fix tests
ildyria 787dfda
fix tests & comments & namespace
ildyria be3066d
readme
ildyria File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| # This is a comment. | ||
| # Each line is a file pattern followed by one or more owners. | ||
|
|
||
| # These owners will be the default owners for everything in | ||
| # the repo. Unless a later match takes precedence, | ||
| # @global-owner1 and @global-owner2 will be requested for | ||
| # review when someone opens a pull request. | ||
|
|
||
| # Default owner for everything in the repo are members of the reviewers team. | ||
|
|
||
| * @LycheeOrg/reviewers | ||
|
|
||
| # Comments bellow are kept for reference | ||
|
|
||
| # Order is important; the last matching pattern takes the most | ||
| # precedence. When someone opens a pull request that only | ||
| # modifies JS files, only @js-owner and not the global | ||
| # owner(s) will be requested for a review. | ||
| # *.js @js-owner #This is an inline comment. | ||
|
|
||
| # You can also use email addresses if you prefer. They'll be | ||
| # used to look up users just like we do for commit author | ||
| # emails. | ||
| # *.go docs@example.com | ||
|
|
||
| # Teams can be specified as code owners as well. Teams should | ||
| # be identified in the format @org/team-name. Teams must have | ||
| # explicit write access to the repository. In this example, | ||
| # the octocats team in the octo-org organization owns all .txt files. | ||
| # *.txt @octo-org/octocats | ||
|
|
||
| # In this example, @doctocat owns any files in the build/logs | ||
| # directory at the root of the repository and any of its | ||
| # subdirectories. | ||
| # /build/logs/ @doctocat | ||
|
|
||
| # The `docs/*` pattern will match files like | ||
| # `docs/getting-started.md` but not further nested files like | ||
| # `docs/build-app/troubleshooting.md`. | ||
| # docs/* docs@example.com | ||
|
|
||
| # In this example, @octocat owns any file in an apps directory | ||
| # anywhere in your repository. | ||
| # apps/ @octocat | ||
|
|
||
| # In this example, @doctocat owns any file in the `/docs` | ||
| # directory in the root of your repository and any of its | ||
| # subdirectories. | ||
| # /docs/ @doctocat | ||
|
|
||
| # In this example, any change inside the `/scripts` directory | ||
| # will require approval from @doctocat or @octocat. | ||
| # /scripts/ @doctocat @octocat | ||
|
|
||
| # In this example, @octocat owns any file in a `/logs` directory such as | ||
| # `/build/logs`, `/scripts/logs`, and `/deeply/nested/logs`. Any changes | ||
| # in a `/logs` directory will require approval from @octocat. | ||
| # **/logs @octocat | ||
|
|
||
| # In this example, @octocat owns any file in the `/apps` | ||
| # directory in the root of your repository except for the `/apps/github` | ||
| # subdirectory, as its owners are left empty. Without an owner, changes | ||
| # to `apps/github` can be made with the approval of any user who has | ||
| # write access to the repository. | ||
| # /apps/ @octocat | ||
| # /apps/github | ||
|
|
||
| # In this example, @octocat owns any file in the `/apps` | ||
| # directory in the root of your repository except for the `/apps/github` | ||
| # subdirectory, as this subdirectory has its own owner @doctocat | ||
| # /apps/ @octocat | ||
| # /apps/github @doctocat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # These are supported funding model platforms | ||
|
|
||
| github: LycheeOrg # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2] | ||
| # patreon: # Replace with a single Patreon username | ||
| open_collective: LycheeOrg | ||
| # ko_fi: # Replace with a single Ko-fi username | ||
| # tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel | ||
| # community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry | ||
| # liberapay: # Replace with a single Liberapay username | ||
| # issuehunt: # Replace with a single IssueHunt username | ||
| # otechie: # Replace with a single Otechie username | ||
| # lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry | ||
| # custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: github-actions | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| groups: | ||
| actions-deps: | ||
| patterns: | ||
| - "*" # Include all GitHub Actions | ||
|
|
||
| - package-ecosystem: composer | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| groups: | ||
| production-dependencies: | ||
| dependency-type: "production" | ||
| development-dependencies: | ||
| dependency-type: "development" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| changelog: | ||
| exclude: | ||
| labels: | ||
| - ignore-for-release | ||
| authors: | ||
| - octocat | ||
| - dependabot | ||
| categories: | ||
| - title: 🏕 Features | ||
| labels: | ||
| - '*' | ||
| exclude: | ||
| labels: | ||
| - dependencies | ||
| - title: 👒 Dependencies | ||
| labels: | ||
| - dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Dependency Review Action | ||
| # | ||
| # This Action will scan dependency manifest files that change as part of a Pull Request, | ||
| # surfacing known-vulnerable versions of the packages declared or updated in the PR. | ||
| # Once installed, if the workflow run is marked as required, | ||
| # PRs introducing known-vulnerable packages will be blocked from merging. | ||
| # | ||
| # Source repository: https://github.com/actions/dependency-review-action | ||
| name: 'Dependency Review' | ||
| on: [pull_request] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| dependency-review: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4 | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - name: 'Checkout Repository' | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| persist-credentials: false | ||
| - name: 'Dependency Review' | ||
| uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5.0.0 | ||
| # with: | ||
| # No fix available yet | ||
| # Note that the model is directly baked into the inage | ||
| # So the risk is limited. | ||
| # allow-ghsas: GHSA-hqmj-h5c6-369m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # This workflow uses actions that are not certified by GitHub. They are provided | ||
| # by a third-party and are governed by separate terms of service, privacy | ||
| # policy, and support documentation. | ||
|
|
||
| name: Scorecard supply-chain security | ||
| on: | ||
| # For Branch-Protection check. Only the default branch is supported. See | ||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection | ||
| branch_protection_rule: | ||
| # To guarantee Maintained check is occasionally updated. See | ||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained | ||
| schedule: | ||
| - cron: '00 02 * * 1' | ||
| push: | ||
| branches: [ "main" ] | ||
|
|
||
| # Declare default permissions as read only. | ||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| analysis: | ||
| name: Scorecard analysis | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| # Needed to upload the results to code-scanning dashboard. | ||
| security-events: write | ||
| # Needed to publish results and get a badge (see publish_results below). | ||
| id-token: write | ||
| # Uncomment the permissions below if installing in a private repository. | ||
| # contents: read | ||
| # actions: read | ||
|
|
||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4 | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - name: "Checkout code" | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: "Run analysis" | ||
| uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a # v2.4.3 | ||
| with: | ||
| results_file: results.sarif | ||
| results_format: sarif | ||
| # (Optional) "write" PAT token. Uncomment the `repo_token` line below if: | ||
| # - you want to enable the Branch-Protection check on a *public* repository, or | ||
| # - you are installing Scorecard on a *private* repository | ||
| # To create the PAT, follow the steps in https://github.com/ossf/scorecard-action#authentication-with-pat. | ||
| # repo_token: ${{ secrets.SCORECARD_TOKEN }} | ||
|
|
||
| # Public repositories: | ||
| # - Publish results to OpenSSF REST API for easy access by consumers | ||
| # - Allows the repository to include the Scorecard badge. | ||
| # - See https://github.com/ossf/scorecard-action#publishing-results. | ||
| # For private repositories: | ||
| # - `publish_results` will always be set to `false`, regardless | ||
| # of the value entered here. | ||
| publish_results: true | ||
|
|
||
| # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF | ||
| # format to the repository Actions tab. | ||
| - name: "Upload artifact" | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: SARIF file | ||
| path: results.sarif | ||
| retention-days: 5 | ||
|
|
||
| # Upload the results to GitHub's code scanning dashboard. | ||
| - name: "Upload to code-scanning" | ||
| uses: github/codeql-action/upload-sarif@08bc0cf022445eacafaa248bf48da20f26b8fd40 # v2.16.4 | ||
| with: | ||
| sarif_file: results.sarif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.