Skip to content

Do not flag propagation on sensitive values#2

Merged
ildyria merged 3 commits into
mainfrom
do-not-flag-propagation-on-sensitive-values
Jul 18, 2026
Merged

Do not flag propagation on sensitive values#2
ildyria merged 3 commits into
mainfrom
do-not-flag-propagation-on-sensitive-values

Conversation

@ildyria

@ildyria ildyria commented Jul 18, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Prevented incorrect sensitive-parameter propagation warnings when values are intentionally wrapped in SensitiveParameterValue.
    • Added coverage to verify that safely wrapped sensitive values are not flagged.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ildyria, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7de60945-12a9-4c83-bf79-3b67c9aa1ccb

📥 Commits

Reviewing files that changed from the base of the PR and between 2c5b9cd and 43329eb.

📒 Files selected for processing (1)
  • tests/Propagation/SensitiveParameterPropagationTest.php
📝 Walkthrough

Walkthrough

The propagation rule now ignores SensitiveParameterValue construction as an intentional safe wrapper. A propagation fixture imports the class and verifies that wrapping a sensitive parameter does not trigger a warning.

Changes

Sensitive value wrapping

Layer / File(s) Summary
Safe wrapping detection and fixture coverage
src/Rules/SensitiveParameterPropagationRule.php, tests/Fixtures/Propagation/PropagationCases.php
resolveCallee() skips propagation checks for SensitiveParameterValue construction, and a fixture verifies the wrapped sensitive parameter is not flagged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A bunny wrapped a secret tight,
In silver-safe code, out of sight.
The rule hopped past,
The test held fast,
And warnings vanished overnight.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ildyria
ildyria merged commit 8e248b0 into main Jul 18, 2026
12 checks passed
@ildyria
ildyria deleted the do-not-flag-propagation-on-sensitive-values branch July 18, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant