Skip to content

Remove false positives#3

Merged
ildyria merged 1 commit into
mainfrom
false-positives
Jul 18, 2026
Merged

Remove false positives#3
ildyria merged 1 commit into
mainfrom
false-positives

Conversation

@ildyria

@ildyria ildyria commented Jul 18, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Sensitive-parameter analysis now recognizes common cryptographic and hashing APIs as safe.
    • Added configuration options for customizing sensitive keywords and safe cryptographic callees.
    • Custom allowlists can include application-specific hashing or encryption methods.
  • Bug Fixes

    • Prevented unnecessary propagation warnings when sensitive values are passed to recognized cryptographic functions.
  • Documentation

    • Expanded the built-in cryptographic allowlist and documented configuration behavior and examples.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Cryptographic callee handling

Layer / File(s) Summary
Rule and configuration wiring
src/Rules/SensitiveParameterPropagationRule.php, extension.neon
The propagation rule recognizes built-in or configured cryptographic functions and methods, while PHPStan parameters provide keyword and crypto-callee configuration.
Crypto propagation fixtures and tests
tests/Fixtures/Propagation/*, tests/Propagation/CryptoPropagationTest.php
Fixtures and tests cover built-in crypto functions, unknown callees, and custom configured safe callees.
Configuration documentation
README.md
Documentation lists built-in crypto callees and explains configuration replacement behavior for keywords and crypto callees.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Poem

I’m a rabbit with hashes tucked under my ear,
Safe callees now hop through without fear.
Passwords and secrets take a crypto-bound flight,
Custom hashers join the allowlist tonight.
Config blooms softly in PHPStan’s light.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3c33e94f-a62b-4cf6-a24b-4602a6ce637c

📥 Commits

Reviewing files that changed from the base of the PR and between 8e248b0 and d9547f2.

📒 Files selected for processing (6)
  • README.md
  • extension.neon
  • src/Rules/SensitiveParameterPropagationRule.php
  • tests/Fixtures/Propagation/CryptoPropagationCases.php
  • tests/Fixtures/Propagation/CustomHasherCases.php
  • tests/Propagation/CryptoPropagationTest.php

Comment thread src/Rules/SensitiveParameterPropagationRule.php
@ildyria
ildyria merged commit e0b2df9 into main Jul 18, 2026
12 checks passed
@ildyria
ildyria deleted the false-positives branch July 18, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant