Repository navigation
Add GPX importer with linked geolocation objects - #1122
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 741ec087f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current importer, including the complete |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7aad124ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c7005e925
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the final head fc84933. All three reported findings are fixed: timezone offsets, structural-point counting and version-independent 24:00:00 normalization. Each has regression tests; the exact uploaded Morning Walk fixture remains covered. All 204 importer and nearby regression checks pass. Exporter follow-up: #1124. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc84933e9f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please verify the latest incremental correction in f1f16c0: artifact hashes now use |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add
gpx_importto import GPX 1.0 and 1.1 as agpxobject containing the original attachment, hashes, metadata, point counts and computed bounds. Every waypoint, route point and track point becomes a linkedgeolocationobject with WGS84 coordinates, elevation, observation time and point context. Geographic observations haveto_ids=false.The module accepts file/paste input through the standard import interface, uses the existing PyMISP templates and requires no new dependencies. Input is limited to 20 MiB, 10,000 points and 32 XML nesting levels; DTDs and invalid point data reject the entire import. Includes API usage and field-mapping documentation.
Validation:
Includes the complete uploaded
tests/fixtures/gpx/Morning_Walk.gpx(197,419 bytes). Its regression test checks all 606 observations, exact attachment recovery, hashes, bounds and object references. Codex findings are fixed with regression tests for invalid timezone offsets, valid 24:00:00 normalization across Python versions, structural-point limits that ignore vendor extension name collisions, and artifact hashing under FIPS restrictions.Companion exporter: #1123 (merged). Its real-file tests and review corrections are in follow-up #1124. The importer can be merged independently.