Skip to content

new: [affected-code] Add affected-code object template - #567

Open
adulau wants to merge 2 commits into
mainfrom
codex/ocsf-1.9-affected-code-20261109
Open

adulau wants to merge 2 commits into
mainfrom
codex/ocsf-1.9-affected-code-20261109

Conversation

@adulau

@adulau adulau commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

A vulnerable source-code location, with one file and an optional line and column range, associated rule and remediation.

file identifies an artifact and vulnerability identifies a flaw; neither records a source-code span identified by a code security scanner.

Existing templates considered: file, vulnerability, ghidra-function.

Use related-to references to file, vulnerability, user-account and scanner rule objects. Create a separate object for each span, keeping range endpoints paired.

OCSF mapping

MISP object relation OCSF source path
filename affected_code.file.path
file-sha256 affected_code.file.hashes
start-line affected_code.start_line
end-line affected_code.end_line
start-column affected_code.start_column
end-column affected_code.end_column
rule-id affected_code.rule.uid
rule-name affected_code.rule.name
remediation affected_code.remediation.desc

Datetime relations use ISO 8601. Importers can prefer the OCSF _time_dt sibling, or convert the corresponding _time epoch milliseconds to a UTC datetime. Unreported booleans remain absent. Source codes, identifiers and strings keep their source meaning; this template is a CTI-oriented subset of the OCSF object.

All attributes default to to_ids: false. Descriptive metadata, local identifiers, counts, flags and timestamps disable correlation; typed network indicators, package URIs and hashes retain correlation where applicable. Nested entities use MISP object references. Source arrays are marked multiple only when their entries can be represented independently.

Example values

These are object-relation/value pairs for one object, with illustrative identifiers:

{
  "filename": "src/handler.py",
  "start-line": 42,
  "end-line": 45,
  "rule-id": "unsafe-query"
}

Validation

  • ./jq_all_the_things.sh and ./validate_all.sh passed on the baseline plus all 29 proposed templates: 483 template definitions, relationship checks, 22 unit tests and unique UUID checks.
  • This template passed JSON Schema validation, required-field reference checks and exact jq -S -j formatting checks against the same baseline.
  • The example loaded and serialized with PyMISP 3.0.0 in strict mode.

This PR adds one version-2 template with a fresh UUID, based directly on main at a9c09f216032bc6093d09f68c743cda2dae29aac. It is part of a review of all 190 base OCSF 1.9.0 objects, compared with the 454 existing MISP templates. The review identified 29 new template proposals; existing-template extensions are recorded separately for future work. No live MISP server round-trip was performed.

Codex review updates

  • Use counter for start-line so the MISP server accepts the valid value zero while preserving whole-number semantics.
  • Use counter for end-line so the MISP server accepts the valid value zero while preserving whole-number semantics.
  • Use counter for start-column so the MISP server accepts the valid value zero while preserving whole-number semantics.
  • Use counter for end-column so the MISP server accepts the valid value zero while preserving whole-number semantics.

Validation after the fixes: all 29 original examples and 20 regression examples passed with PyMISP 3.0.0 in strict mode; 69 regression checks passed against the unmodified MISP 2.5 PHP attribute validator, including zero/nonzero values, negative rejection and NetBIOS authorities. The complete repository validation suite was rerun on all 483 template definitions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T16:31:23.459134Z 6c79008 PR opened
🔒 Security Review ✅ Completed 2026-11-09T16:32:04.992737Z 6c79008 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant