Skip to content

new: [data-classification] Add data-classification object template - #580

Merged
adulau merged 2 commits into
mainfrom
codex/ocsf-1.9-data-classification-20261109
Nov 12, 2026
Merged

adulau merged 2 commits into
mainfrom
codex/ocsf-1.9-data-classification-20261109

Conversation

@adulau

@adulau adulau commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

One data classification or DLP observation, including source category, confidentiality, classifier, lifecycle and detection context. It records source labels without imposing a universal classification vocabulary.

open-data-security describes an open dataset and confidentiality-impact records loss; neither captures classifier output, DLP pattern and data lifecycle on a discovered resource.

Existing templates considered: open-data-security, confidentiality-impact.

Use related-to references to the inspected file, database or cloud-storage-bucket, and the security-policy. Keep each classifier/category observation separate.

OCSF mapping

MISP object relation OCSF source path
category data_classification.category
confidentiality data_classification.confidentiality
classification-id data_classification.uid
classifier-id data_classification.classifier_details.uid
classifier-name data_classification.classifier_details.name
classifier-type data_classification.classifier_details.type
status data_classification.status
size data_classification.size
total data_classification.total
reference data_classification.src_url
lifecycle-state data_security.data_lifecycle_state
detection-system data_security.detection_system
detection-pattern data_security.detection_pattern
pattern-match data_security.pattern_match

Datetime relations use ISO 8601. Importers can prefer the OCSF _time_dt sibling, or convert the corresponding _time epoch milliseconds to a UTC datetime. Unreported booleans remain absent. Source codes, identifiers and strings keep their source meaning; this template is a CTI-oriented subset of the OCSF object.

All attributes default to to_ids: false. Descriptive metadata, local identifiers, counts, flags and timestamps disable correlation; typed network indicators, package URIs and hashes retain correlation where applicable. Nested entities use MISP object references. Source arrays are marked multiple only when their entries can be represented independently.

Example values

These are object-relation/value pairs for one object, with illustrative identifiers:

{
  "category": "Personal Information",
  "confidentiality": "Confidential",
  "classifier-name": "PII detector"
}

Validation

  • ./jq_all_the_things.sh and ./validate_all.sh passed on the baseline plus all 29 proposed templates: 483 template definitions, relationship checks, 22 unit tests and unique UUID checks.
  • This template passed JSON Schema validation, required-field reference checks and exact jq -S -j formatting checks against the same baseline.
  • The example loaded and serialized with PyMISP 3.0.0 in strict mode.

This PR adds one version-2 template with a fresh UUID, based directly on main at a9c09f216032bc6093d09f68c743cda2dae29aac. It is part of a review of all 190 base OCSF 1.9.0 objects, compared with the 454 existing MISP templates. The review identified 29 new template proposals; existing-template extensions are recorded separately for future work. No live MISP server round-trip was performed.

Codex review updates

  • Use counter for size so the MISP server accepts the valid value zero while preserving whole-number semantics.
  • Accept DLP observations identified only by a detection pattern, lifecycle state or detection system, including redacted-content observations.

Validation after the fixes: all 29 original examples and 20 regression examples passed with PyMISP 3.0.0 in strict mode; 69 regression checks passed against the unmodified MISP 2.5 PHP attribute validator, including zero/nonzero values, negative rejection and NetBIOS authorities. The complete repository validation suite was rerun on all 483 template definitions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T16:37:53.466749Z cc00814 PR opened
🔒 Security Review ✅ Completed 2026-11-09T16:37:46.294280Z cc00814 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc00814deb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@adulau
adulau merged commit d6974f0 into main Nov 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant