Repository navigation
new: [data-classification] Add data-classification object template - #580
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc00814deb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One data classification or DLP observation, including source category, confidentiality, classifier, lifecycle and detection context. It records source labels without imposing a universal classification vocabulary.
open-data-security describes an open dataset and confidentiality-impact records loss; neither captures classifier output, DLP pattern and data lifecycle on a discovered resource.
Existing templates considered:
open-data-security,confidentiality-impact.Use related-to references to the inspected file, database or cloud-storage-bucket, and the security-policy. Keep each classifier/category observation separate.
OCSF mapping
categorydata_classification.categoryconfidentialitydata_classification.confidentialityclassification-iddata_classification.uidclassifier-iddata_classification.classifier_details.uidclassifier-namedata_classification.classifier_details.nameclassifier-typedata_classification.classifier_details.typestatusdata_classification.statussizedata_classification.sizetotaldata_classification.totalreferencedata_classification.src_urllifecycle-statedata_security.data_lifecycle_statedetection-systemdata_security.detection_systemdetection-patterndata_security.detection_patternpattern-matchdata_security.pattern_matchDatetime relations use ISO 8601. Importers can prefer the OCSF
_time_dtsibling, or convert the corresponding_timeepoch milliseconds to a UTC datetime. Unreported booleans remain absent. Source codes, identifiers and strings keep their source meaning; this template is a CTI-oriented subset of the OCSF object.All attributes default to
to_ids: false. Descriptive metadata, local identifiers, counts, flags and timestamps disable correlation; typed network indicators, package URIs and hashes retain correlation where applicable. Nested entities use MISP object references. Source arrays are markedmultipleonly when their entries can be represented independently.Example values
These are object-relation/value pairs for one object, with illustrative identifiers:
{ "category": "Personal Information", "confidentiality": "Confidential", "classifier-name": "PII detector" }Validation
./jq_all_the_things.shand./validate_all.shpassed on the baseline plus all 29 proposed templates: 483 template definitions, relationship checks, 22 unit tests and unique UUID checks.jq -S -jformatting checks against the same baseline.This PR adds one version-2 template with a fresh UUID, based directly on
mainata9c09f216032bc6093d09f68c743cda2dae29aac. It is part of a review of all 190 base OCSF 1.9.0 objects, compared with the 454 existing MISP templates. The review identified 29 new template proposals; existing-template extensions are recorded separately for future work. No live MISP server round-trip was performed.Codex review updates
Validation after the fixes: all 29 original examples and 20 regression examples passed with PyMISP 3.0.0 in strict mode; 69 regression checks passed against the unmodified MISP 2.5 PHP attribute validator, including zero/nonzero values, negative rejection and NetBIOS authorities. The complete repository validation suite was rerun on all 483 template definitions.