Skip to content

Parse table/shadowbuff.xml - #91

Merged
AngeloTadeucci merged 2 commits into
masterfrom
shadow-buff
Oct 30, 2026
Merged

AngeloTadeucci merged 2 commits into
masterfrom
shadow-buff

Conversation

@Zintixx

@Zintixx Zintixx commented Oct 30, 2026 •

Copy link
Copy Markdown

Adds a parser type for table/shadowbuff.xml, the Shadow Expedition traits: 16 common traits and 10 per class, each with 20 levels. A server reviving the expedition's trait window needs it for each trait's class, icon, per-level cost and effect ids. Bumps the package to 2.4.33.

  • Xml/Table/ShadowBuff.cs: the row and level types. Rows are feature-gated (ShadowExpedition, or SoulBinder for Soul Binder's), so the root uses M2dFeatureLocale with id as the selector, as DungeonRoom does. jobCode is 0 on the common traits. addifectGuids keeps retail's spelling and is a long[], since the ids are 10 digits. levelUpCost is absent, so 0, on a class's free level 1.
  • TableParser.ParseShadowBuff(): yields (id, row), as ParseClubBuff does.
  • TableParserTest.TestShadowBuff: checks every row's id and that its levels are 1-20, and pins trait 211001 to the XML: jobCode 110, level 2's levelUpCost 40 and first effect id 9201100102.

Verification

  • dotnet test Maple2.File.Tests --filter TestShadowBuff passes.
  • The full suite gives the same 34 failures with and without this change, against the same local client data. They are data-dependent, not parser failures, as in Parse table/Server/shadowExpeditionDrop.xml #90.
  • A local 2.4.33-debug.0 build of this branch drives the server's ingest of the table, and all 126 traits ingest.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f0d6255-2bb2-47cd-a1c1-ba61491ad88b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AngeloTadeucci
AngeloTadeucci merged commit 5f4aa8d into master Oct 30, 2026
3 checks passed
@AngeloTadeucci
AngeloTadeucci deleted the shadow-buff branch October 30, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants