Repository navigation
Parse table/shadowbuff.xml - #91
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parser type for
table/shadowbuff.xml, the Shadow Expedition traits: 16 common traits and 10 per class, each with 20 levels. A server reviving the expedition's trait window needs it for each trait's class, icon, per-level cost and effect ids. Bumps the package to 2.4.33.Xml/Table/ShadowBuff.cs: the row and level types. Rows are feature-gated (ShadowExpedition, orSoulBinderfor Soul Binder's), so the root usesM2dFeatureLocalewithidas the selector, asDungeonRoomdoes.jobCodeis 0 on the common traits.addifectGuidskeeps retail's spelling and is along[], since the ids are 10 digits.levelUpCostis absent, so 0, on a class's free level 1.TableParser.ParseShadowBuff(): yields(id, row), asParseClubBuffdoes.TableParserTest.TestShadowBuff: checks every row's id and that its levels are 1-20, and pins trait 211001 to the XML:jobCode110, level 2'slevelUpCost40 and first effect id 9201100102.Verification
dotnet test Maple2.File.Tests --filter TestShadowBuffpasses.2.4.33-debug.0build of this branch drives the server's ingest of the table, and all 126 traits ingest.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.