Skip to content

Add positive collision avoidance to CatalogUniformSampler - #331

Open
Xenostrike78 wants to merge 1 commit into
MTSWebServices:mainfrom
Xenostrike78:feature/catalog-sampler-avoid-positive-collisions
Open

Xenostrike78 wants to merge 1 commit into
MTSWebServices:mainfrom
Xenostrike78:feature/catalog-sampler-avoid-positive-collisions

Conversation

@Xenostrike78

Copy link
Copy Markdown

Summary

  • Add optional avoid_positive_collisions parameter to CatalogUniformSampler.
  • Redraw sampled negatives that collide with positive targets when enabled.
  • Preserve default sampling behaviour when the option is disabled.
  • Add tests for default behaviour, collision avoidance, and one-pass redrawing.

Testing

  • 3 new sampler tests passed.
  • 80 existing SASRec/BERT4Rec tests passed.
  • 41 tests skipped (GPU-related).
  • git diff --check passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant