Conversation
…rding Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
已直接 squash 进 main(72f67c6),这条 PR 和 main 分叉合不进去。 |
There was a problem hiding this comment.
🟢 Approval recommended
The fixture matches the replay controller’s JSONL input and removes the redundant screencap while preserving the remaining recording sequence.
Pull request overview
Updates the PipelineSmoking replay fixture to use JSONL and remove the redundant initial screenshot record.
Changes:
- Deletes the legacy
MaaRecording.txtfixture. - Adds
MaaRecording.jsonlwithout the unused initial DirectHit screencap.
File summaries
| File | Description |
|---|---|
PipelineSmoking/MaaRecording.txt |
Removes the obsolete recording format. |
PipelineSmoking/MaaRecording.jsonl |
Adds the corrected replay recording fixture. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
配合 MaaXYZ/MaaFramework#1282
Sourcery 总结
更新 PipelineSmoking 录制 fixture,移除未使用的初始 DirectHit 截图条目。
Bug 修复:
测试:
Original summary in English
Summary by Sourcery
Update the PipelineSmoking recording fixture to remove the unused initial DirectHit screencap entry.
Bug Fixes:
Tests: