Skip to content

test: drop unused DirectHit entry screencap - #2

Closed
MistEO wants to merge 2 commits into
mainfrom
fix/skip-screencap-direct-hit
Closed

MistEO wants to merge 2 commits into
mainfrom
fix/skip-screencap-direct-hit

Conversation

@MistEO

@MistEO MistEO commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • PipelineSmoking 入口 Wilderness 是 DirectHit,MaaFramework 跳过 screencap 后录制会错位
  • 去掉第一条多余的 screencap 记录

配合 MaaXYZ/MaaFramework#1282

Sourcery 总结

更新 PipelineSmoking 录制 fixture,移除未使用的初始 DirectHit 截图条目。

Bug 修复:

  • 移除冗余的初始截图录制,以便在 DirectHit 条目跳过截图时,PipelineSmoking 录制仍保持对齐。

测试:

  • 使用更新后的 JSONL 录制 fixture 替换旧版 MaaRecording 文本 fixture。
Original summary in English

Summary by Sourcery

Update the PipelineSmoking recording fixture to remove the unused initial DirectHit screencap entry.

Bug Fixes:

  • Remove the redundant initial screencap recording so PipelineSmoking recordings remain aligned when DirectHit entries skip screencaps.

Tests:

  • Replace the legacy MaaRecording text fixture with the updated JSONL recording fixture.

Copilot AI lite review requested due to automatic review settings September 17, 2026 09:56

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好——我已经审阅了你的更改,整体看起来很棒!


Sourcery 对开源项目免费——如果你喜欢我们的审阅结果,请考虑分享它们 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@MistEO

MistEO commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

已直接 squash 进 main(72f67c6),这条 PR 和 main 分叉合不进去。

@MistEO MistEO closed this Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The fixture matches the replay controller’s JSONL input and removes the redundant screencap while preserving the remaining recording sequence.

Pull request overview

Updates the PipelineSmoking replay fixture to use JSONL and remove the redundant initial screenshot record.

Changes:

  • Deletes the legacy MaaRecording.txt fixture.
  • Adds MaaRecording.jsonl without the unused initial DirectHit screencap.
File summaries
File Description
PipelineSmoking/MaaRecording.txt Removes the obsolete recording format.
PipelineSmoking/MaaRecording.jsonl Adds the corrected replay recording fixture.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants