Repository navigation
fix(ci): load prod deploy secrets from Infisical over GitHub OIDC - #355
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 30, 2026 in 1m 15s
Confidence 9/10 · No issues found
🟢 Confidence 9/10 · safe to merge. No defects found; the open risk is whether Infisical prod holds the exact key names the deploy reads.
no findings · tests not needed · risk high −1
The prod deploy now takes every secret from Infisical over GitHub OIDC instead of the empty production environment, and the same PR reworks the web kit's type, surfaces and sidebar states and adds a screenshot gallery. Nothing in it is unsafe to merge.
deploy-prd.ymlexports Infisicalprodover OIDC withid-token: write- Job-level secret list dropped so the action's
GITHUB_ENVvalues survive - New
fg-1..4,wash,field,shadow-controltokens replace accent and input borders design.gallery.tsscreenshots the kit in light and dark
Before merge
- Env var · Set
VITE_GALLERY_LABELin every environment, or confirm its default ·apps/web-foldkit/src/design.gallery.ts:215 - Env var · Add
INFISICAL_IDENTITY_IDto theproductionenvironment variables ·.github/workflows/deploy-prd.yml:52 - Manual · Confirm Infisical
prodcarries every key the deploy reads (S3_BUCKET,GITHUB_APP_ID,MAPLE_API_KEY); nothing in the diff checks the names
What was checked
- Infisical step runs before both consuming steps, so its
GITHUB_ENVvalues are set (deploy-prd.yml:45) - OIDC subject
…:environment:productionmatches the job'senvironment: production(deploy-prd.yml:30) design.gallery.tsmisses vitest's default include, sobun run teststays node-only (vite.config.ts:43)
0944356 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading