Skip to content

fix(ci): load prod deploy secrets from Infisical over GitHub OIDC - #355

Merged
Makisuo merged 3 commits into
mainfrom
fix/deploy-prd-infisical-oidc
Oct 30, 2026
Merged

Makisuo merged 3 commits into
mainfrom
fix/deploy-prd-infisical-oidc

fix(ci): document the immutable OIDC subject the Infisical identity i…

0944356
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Oct 30, 2026 in 1m 15s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge. No defects found; the open risk is whether Infisical prod holds the exact key names the deploy reads.
no findings · tests not needed · risk high −1

The prod deploy now takes every secret from Infisical over GitHub OIDC instead of the empty production environment, and the same PR reworks the web kit's type, surfaces and sidebar states and adds a screenshot gallery. Nothing in it is unsafe to merge.

  • deploy-prd.yml exports Infisical prod over OIDC with id-token: write
  • Job-level secret list dropped so the action's GITHUB_ENV values survive
  • New fg-1..4, wash, field, shadow-control tokens replace accent and input borders
  • design.gallery.ts screenshots the kit in light and dark

Before merge

  • Env var · Set VITE_GALLERY_LABEL in every environment, or confirm its default · apps/web-foldkit/src/design.gallery.ts:215
  • Env var · Add INFISICAL_IDENTITY_ID to the production environment variables · .github/workflows/deploy-prd.yml:52
  • Manual · Confirm Infisical prod carries every key the deploy reads (S3_BUCKET, GITHUB_APP_ID, MAPLE_API_KEY); nothing in the diff checks the names
What was checked
  • Infisical step runs before both consuming steps, so its GITHUB_ENV values are set (deploy-prd.yml:45)
  • OIDC subject …:environment:production matches the job's environment: production (deploy-prd.yml:30)
  • design.gallery.ts misses vitest's default include, so bun run test stays node-only (vite.config.ts:43)

0944356 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.