style(web): toolbar searches at the toolbar size, page gaps through dashboardPage by Makisuo · Pull Request #1994 · MapleTechLabs/maple

Makisuo · 2026-10-30T20:38:55Z

Stacked on #1993 (which is on #1992). Part of the dashboard consistency review: one control height per toolbar, and page spacing set in one place.

Changes

Toolbar searches at the toolbar size. Eight list toolbars passed size: "default" (32px) to searchInput, next to 28px buttons, refresh buttons and filter chips. They now use sm, like the errors and code-review toolbars already do: agent sessions, agent tools, replays, investigations, metrics, dashboards, the alert rules tab, and the shared infra toolbar (hosts, containers, Cloudflare, GCP, PlanetScale, Railway, Supabase). The dashboards list's two outline "Tags" buttons move to sm with it.
Page gaps through dashboardPage. 18 pages set gap-6 or gap-4 by hand through scrollClassName; they now use the existing gap: "lg" | "md" option. It puts the same class on the same element, so nothing moves.

Before	After

Verification

bun run typecheck passes in apps/web.
Vitest, scoped to the touched areas (alerts hub, replays, agent-sessions, investigations, infra, infra-integrations, dashboards, metrics, analytics, code-review): 90 files, 561 tests pass.
Screenshots: headless Chromium at 2x on /lab/agent-sessions, /lab/agent-tools, /lab/replays, /lab/infra, /lab/cloudflare and /lab/gcp-infra, in light and dark, against feat(web): text link, card button and dashed button in the kit #1993's head and this branch, compared with a pixel diff. The only differences are the 4px shorter searches and the rows below them moving up.

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

coderabbitai · 2026-10-30T20:39:03Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 192828fb-efda-42a9-9161-b5032fa223d4

Commits

Reviewing files that changed from the base of the PR and between 04dfb58 and d26adec.

Files selected for processing: 29

apps/web/src/page/agent-sessions/list/view-toolbar.ts
apps/web/src/page/agent-sessions/tools-kit/toolbar.ts
apps/web/src/page/alerts/hub/view-rules.ts
apps/web/src/page/analytics/view.ts
apps/web/src/page/code-review/kit/layout.ts
apps/web/src/page/dashboards/kit/list-parts.ts
apps/web/src/page/dashboards/list/view-list.ts
apps/web/src/page/dashboards/list/view-tag-filter.ts
apps/web/src/page/dashboards/templates/view-list.ts
apps/web/src/page/infra-integrations/aws/list/view.ts
apps/web/src/page/infra-integrations/aws/resource/view.ts
apps/web/src/page/infra-integrations/cloudflare/list/view.ts
apps/web/src/page/infra-integrations/cloudflare/worker/view.ts
apps/web/src/page/infra-integrations/cloudflare/zone/view.ts
apps/web/src/page/infra-integrations/gcp/list/view.ts
apps/web/src/page/infra-integrations/gcp/workload/view.ts
apps/web/src/page/infra-integrations/planetscale/db/view.ts
apps/web/src/page/infra-integrations/planetscale/list/view.ts
apps/web/src/page/infra-integrations/railway/list/view.ts
apps/web/src/page/infra-integrations/railway/service/view.ts
apps/web/src/page/infra-integrations/supabase/list/view.ts
apps/web/src/page/infra-integrations/supabase/project/view.ts
apps/web/src/page/infra/containers/detail/view.ts
apps/web/src/page/infra/containers/list/view.ts
apps/web/src/page/infra/hosts/list/view.ts
apps/web/src/page/infra/kit/page-parts.ts
apps/web/src/page/investigations/list/view.ts
apps/web/src/page/metrics/browse/view.ts
apps/web/src/page/replays/kit/replays-toolbar.ts

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-30T20:43:29Z

🍁 Maple PR preview

Note

Preview resources were removed when the preview label came off.

Final commit d26adec · View workflow run

…ashboardPage Eight list toolbars forced a 32px search next to 28px buttons and chips; they now use sm like the rest. Pages that set gap-4/gap-6 through scrollClassName use the gap option instead (same class, same element).

…size They stayed 32px next to the now-28px searches. Comments that still called the search the default size are updated.

…ct at the toolbar size

Makisuo · 2026-10-30T21:40:56Z

Preview check (app-pr-1994.maple.dev, 1440x900, the getBoundingClientRect().height of every control in each toolbar row)

Page	Heights	Result
/agent-sessions	search 28, Reload 28	Pass
/agent-sessions/tools	search 28, service/model/env selects 28, time range 28, Reload 28	Pass
/replays	search 28, quick filters 28	Pass
/metrics	search 28, metric type select 28	Pass
/dashboards	scope segmented 28, search 28, Tags 28, sort 28	Pass
/dashboards/templates	search 28, readiness segmented 28	Pass

Search still filters: /metrics ?q=http takes the list from 29 lines to 11, and /dashboards/templates "redis" from 23 templates to 1.
Page spacing: /code-review's section column (moved to gap: "lg") keeps its 24px row gap.
Not testable on this preview: /alerts Rules (the sync service isn't deployed with preview:web), and /alerts Uptime, /investigations, /infra* and /analytics, which have no data in the preview org and so show no toolbar. Nothing was created to work around this.
Smoke: /, /traces and /logs have no page or console errors besides the sync service 503s.

Traces: this PR only changes classes in the browser bundle and adds no backend path or query.

maple-review-bot · 2026-10-30T21:42:34Z

Maple review

🟢 Confidence 8/10 · likely safe to merge. Held at 8 because earlier reviews of this pull request found 3 defects.
_{no findings · tests not needed · risk low · 3 defects fixed in earlier rounds}

Parent styling pass: eight list toolbars move their search (and the dashboards selects/buttons) to size: "sm", and 18 pages swap hand-written scrollClassName: "gap-6"/"gap-4" for gap: "lg"/"md" on dashboardPage. The classes that reach the DOM are unchanged apart from the intended 32→28px controls, so it is safe to merge.

searchInput in eight list toolbars now passes size: "sm"
Dashboards scope/sort/tags controls and templates readiness filter drop to sm
Investigations and metrics selects take size: "sm"
18 pages use dashboardPage's gap: "lg" | "md" instead of scrollClassName

_{d26adec · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.}

Makisuo added the preview:web Deploy a Workers-only PR preview (no ingest/Electric); see docs/pr-previews.md label Oct 30, 2026

Makisuo deployed to pr-preview October 30, 2026 20:39 — with GitHub Actions Active