Repository navigation
perf(landing): subset Geist and Geist Mono to what the site renders - #1995
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Oct 30, 2026 in 1m 40s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Delta is a two-line escape-regex fix in a hand-run generator; the rest of the script is unchanged and the committed subsets still match it.
no findings · tests not needed · risk low
Since the last review only ESCAPE changed: \uXXXX now takes exactly four hex digits and \u{...} one to six, with codepoints past U+10FFFF dropped, which is what JS itself allows. The collected character set, so the committed subsets, are unchanged.
ESCAPEreads unbraced\uescapes as exactly four digits, braced ones as one to sixcontent()drops escaped codepoints above U+10FFFF instead of raising inchr()
Production impact
Production traffic of the changed files (last 7 days)
| File | Calls/day | Busiest operations |
|---|---|---|
apps/landing/src/layouts/DocsLayout.astro |
33 | GET /favicon.ico 33/day, 0.0% err |
What was checked
a or bincontent()picks the matched alternation group, so empty strings never reachint(..., 16)(subset-fonts.py:207,:228)- Core
unicode-rangeat head still lists U+0009-000A, U+200B, U+2011, matching theALIASEStable (fonts.generated.css:13) - Font filenames the script writes match what
FontPreloads.astro:5-6andfonts.generated.cssimport
97d9e82 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading