Repository navigation
fix(web): infra meta lines end in an ellipsis instead of clipping the last item - #1997
Conversation
Maple review🟢 Confidence 10/10 · safe to merge. One-line class change in a pure view helper; every Lets the last Findings🔵 Note · F1 · Only plain-string last items get the new ellipsis; node items still clipcorrectness · Line 38 caps and truncates only plain strings, so a node last item shrinks without any 🤖 Prompt to fix this finding with an AI agent
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Item shrink behavior apps/web/src/page/infra/kit/meta-line.ts |
metaLine applies min-w-0 to the last item and shrink-0 to preceding items. A comment describes the last-item overflow behavior. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Suggested labels: preview
Merge Risk: 
Minimal · up to 50ab2
-
No actionable merge-blocking risk is evident in the reviewed change.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title names the main change: infra meta lines now end in an ellipsis instead of clipping the last item. The raw summary confirms the change to metaLine in apps/web/src/page/infra/kit/meta-line.ts, where the last item can shrink (min-w-0) so its truncation shows an ellipsis. The title is specific, uses the conventional fix(web) prefix, and does not describe anything absent from the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
Follow-up to #1992. Infra list rows show a sub-line like
Function 1st gen · europe-west1 · acme-data. Every item inmetaLinewasshrink-0, so when the line overflowed, the last item was clipped mid-word with no ellipsis (acme-dat). #1992 made this visible on the GCP table, where the numeric columns rounded up to the width scale and the service column got about 26px narrower. The last item now shrinks (min-w-0), so its owntruncateends it in an ellipsis. Applies to every infra table that usesmetaLine.Screenshots
/lab/gcp-infra, dark, 1440px.Verification
apps/webtypecheck clean,oxlint -c .oxlintrc.effect.jsonclean.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit