Repository navigation
Conversation
itzanway
force-pushed
the
fix-mdev-40868
branch
from
October 19, 2026 17:42
d27f7df to
b405ea0
Compare
gkodinov
added
the
External Contribution
gkodinov
approved these changes
Oct 20, 2026
gkodinov
left a comment
gkodinov
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
LGTM. Please stand by for the final review.
Contributor
|
@itzanway I shared with you an additional commit that should fix the silent ignore of the conversion errors. Plz take a look. |
Catch DuckDB conversion exceptions in send_data, raise a MariaDB error, and return -1.
itzanway
force-pushed
the
fix-mdev-40868
branch
from
October 23, 2026 18:26
b405ea0 to
51c8905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDB Value::CastAs can throw while converting InnoDB rows (for example zero DATETIME) during a cross-engine UNION. Catch the exception, raise a MariaDB error, and return -1 so fiber_scan_func can map thd->is_error() to state->error without aborting the server.
https://jira.mariadb.org/browse/MDEV-40868