A test for the hop that has failed three times - #3
Merged
Merged
Conversation
…ers. Lifted buildModel into models/build.ts so it can be tested without booting the server. docs/12 records three silent failures on this path; the tests assert the client and the address it was handed, which is what tells them apart without a live vendor. Biome was also checking a local plugin's cache file, so the documented local gate failed on a file CI never sees. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildModelchose the chat client insideindex.ts, which cannot be imported without booting the server — so the one hop docs/12 records failing three times (parsed but dropped, wrong key, never read back) had no test. A wrong client still answers, so nothing outside notices.models/build.ts(new file, per CLAUDE.md) holds the body;index.tskeeps the env-derived defaults and calls it.biome.jsonstops checking**/.impeccable, a local tool's cache that made the documented format gate fail on a file CI never sees.Verified:
format:check,lint,typecheck, andtest:ci(2243 pass, 0 fail) against a real pgvector database.🤖 Generated with Claude Code