Delete the pre-upgrade dump once the upgrade succeeds - #6
Merged
Merged
Conversation
Nothing reads the dump once the new image is up — there is no rollback after a success — so it sat in Application Support until the next upgrade overwrote it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dump exists so a rollback can undo a migration the old image cannot read. After a successful upgrade nothing reads it — there is no roll back to a previous engine from there — so it stayed in Application Support: a plain-SQL copy of the person's conversations and agents, until the next upgrade happened to overwrite it.
removeDump()used by both the success path and uninstall, rather than the same two lines twice.Verified:
swift build --build-tests && swift testgreen.🤖 Generated with Claude Code