Allow triple left click on a TextBox to select all text - #4081
Open
JLdgu wants to merge 1 commit into
Open
Conversation
corvinsz
requested changes
Aug 13, 2026
corvinsz
left a comment
Member
There was a problem hiding this comment.
I few things I noticed:
- We should type check against
TextBoxBaseso this behavior also works for theRichTextBox - Maybe an example dedicated to this attached property with a small description would be helpful, especially because this behavior is not something consumers can "just see". Please don't forget the MD3 demo app 😄
- In my opinion the test you added should also test the negative (
materialDesign:TextFieldAssist.SelectAllOnTripleClick="False") behavior to prevent any regressions.
| DependencyObject d, | ||
| DependencyPropertyChangedEventArgs e) | ||
| { | ||
| if (d is TextBox textBox) |
Member
There was a problem hiding this comment.
Suggested change
| if (d is TextBox textBox) | |
| if (d is TextBoxBase textBox) |
| object sender, | ||
| MouseButtonEventArgs e) | ||
| { | ||
| if (e.ClickCount == 3 && sender is TextBox textBox) |
Member
There was a problem hiding this comment.
Suggested change
| if (e.ClickCount == 3 && sender is TextBox textBox) | |
| if (e.ClickCount == 3 && sender is TextBoxBase textBox) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triple clicking in a textbox to select all text is a common action on Windows applications