Repository navigation
Fix Calendar mouse capture preventing dialog close on first click - #4117
Open
MORTEM3845 wants to merge 1 commit into
Open
MORTEM3845 wants to merge 1 commit into
MORTEM3845 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3971.
Release CalendarItem's own mouse capture after left mouse-up, including handled events, so the first click on OK closes the dialog. Selection finishes before capture is released, preserving range dragging.
Validation: builds for net462, net8.0-windows and net10.0-windows. Local XamlTest checks passed on .NET 10 with MD2/MD3: both DialogHost styles, SingleRange/MultipleRange dragging, keyboard and month navigation, and standalone Calendar clicks. Disabling the fix reproduced the lost first click. The main UI test project could not build locally due to TUnit compilation errors.