storage: let one persist sink batch span multiple timestamps - #38934
Draft
martykulma wants to merge 1 commit into
Draft
martykulma wants to merge 1 commit into
martykulma wants to merge 1 commit into
Conversation
BatchBuilderAndMetadata no longer pins a batch to a single timestamp. It tracks the largest timestamp staged instead, which is what append_batches needs to tell a batch entirely below a raised append lower from one that straddles it. The straddling batch is re-appended under the narrowed description and persist filters the out-of-bounds updates on read. No behavior change: write_batches still opens a builder per timestamp, so the largest staged timestamp is the only one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
martykulma
added this pull request to stack #38937
September 19, 2026 00:30
martykulma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchBuilderAndMetadatapinned a batch to one timestamp, which blocks anygrouping across timestamps.
Now it tracks the largest timestamp staged. That's what
append_batchesneedsafter an
UpperMismatchto tell a batch entirely below a raised lower, whichgets deleted, from one that straddles it, which is re-appended under the
narrowed description with persist filtering the rest on read.
No behavior change,
write_batchesstill opens a builder per timestamp so thelargest staged is the only one.
a_straddling_batch_is_usable_under_a_raised_lowercovers it end to end.🤖 Generated with Claude Code